[MediaWiki-commits] [Gerrit] |1= should be always used. Following standard on commons. - change (mediawiki/core)

2015-12-06 Thread Zhuyifei1999 (Code Review) 
Zhuyifei1999 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/257174

Change subject: |1= should be always used. Following standard on commons.
..

|1= should be always used. Following standard on commons.


This reverts commit 02c2cbc166f720a4d8b0d957e0a908893822e0b4.
Bug: T119691
Change-Id: Ied787ecb91aaae3f643c9d013b8982ddabea8142
---
M resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/74/257174/1

diff --git a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js 
b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
index 5e79039..c336676 100644
--- a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
+++ b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
@@ -136,12 +136,11 @@
 * @return {string}
 */
ForeignStructuredUpload.prototype.getDescriptions = function () {
-   var i, desc, hasEquals, templateCalls = [];
+   var i, desc, templateCalls = [];
 
for ( i = 0; i < this.descriptions.length; i++ ) {
desc = this.descriptions[ i ];
-   hasEquals = desc.text.indexOf( '=' ) !== -1;
-   templateCalls.push( '{{' + desc.language + ( hasEquals 
? '|1=' : '|' ) + desc.text + '}}' );
+   templateCalls.push( '{{' + desc.language + '|' + 
desc.text + '}}' );
}
 
return templateCalls.join( '\n' );

-- 
To view, visit https://gerrit.wikimedia.org/r/257174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied787ecb91aaae3f643c9d013b8982ddabea8142
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Zhuyifei1999 
Gerrit-Reviewer: Steinsplitter 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] |1= should be always used. Following standard on commons. - change (mediawiki/core)

2015-12-05 Thread Steinsplitter (Code Review) 
Steinsplitter has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/257172

Change subject: |1= should be always used. Following standard on commons.
..

|1= should be always used. Following standard on commons.

This reverts commit 02c2cbc166f720a4d8b0d957e0a908893822e0b4.

Change-Id: Ied787ecb91aaae3f643c9d013b8982ddabea8142
---
M resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/257172/1

diff --git a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js 
b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
index 5e79039..c336676 100644
--- a/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
+++ b/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.js
@@ -136,12 +136,11 @@
 * @return {string}
 */
ForeignStructuredUpload.prototype.getDescriptions = function () {
-   var i, desc, hasEquals, templateCalls = [];
+   var i, desc, templateCalls = [];
 
for ( i = 0; i < this.descriptions.length; i++ ) {
desc = this.descriptions[ i ];
-   hasEquals = desc.text.indexOf( '=' ) !== -1;
-   templateCalls.push( '{{' + desc.language + ( hasEquals 
? '|1=' : '|' ) + desc.text + '}}' );
+   templateCalls.push( '{{' + desc.language + '|' + 
desc.text + '}}' );
}
 
return templateCalls.join( '\n' );

-- 
To view, visit https://gerrit.wikimedia.org/r/257172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied787ecb91aaae3f643c9d013b8982ddabea8142
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.27.0-wmf.7
Gerrit-Owner: Steinsplitter 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits