[MediaWiki-commits] [Gerrit] Add 'Send Feedback' iten to left nav - change (apps...wikipedia)

2014-03-06 Thread Yuvipanda (Code Review) 
Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/117323

Change subject: Add 'Send Feedback' iten to left nav
..

Add 'Send Feedback' iten to left nav

Will be stripped out before market release.

Change-Id: I80ca683115e7454d7cded126cb3223d5ba08ad52
---
M wikipedia/res/values/strings.xml
M wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
2 files changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/23/117323/1

diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml
index 7b3fc22..ca74299 100644
--- a/wikipedia/res/values/strings.xml
+++ b/wikipedia/res/values/strings.xml
@@ -111,4 +111,5 @@
 string name=edit_preview_fetching_dialog_messageFetching 
preview.../string
 string name=edit_preview_activity_titlePreview edit/string
 string name=create_account_logging_inLogging in.../string
+string name=nav_item_send_feedbackSend feedback/string
 /resources
diff --git a/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java 
b/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
index 0cb4a8b..9823705 100644
--- a/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
@@ -3,6 +3,7 @@
 import android.app.*;
 import android.content.*;
 import android.graphics.*;
+import android.net.*;
 import android.os.*;
 import android.support.v4.app.Fragment;
 import android.view.*;
@@ -18,13 +19,15 @@
 R.string.nav_item_saved_pages,
 R.string.nav_item_preferences,
 R.string.nav_item_login,
+R.string.nav_item_send_feedback,
 R.string.zero_free_verbiage
 };
 private static final int[] ACTION_ITEM_IMAGES = {
 android.R.drawable.ic_menu_recent_history,
 android.R.drawable.ic_menu_save,
 android.R.drawable.ic_menu_preferences,
-android.R.drawable.ic_menu_add
+android.R.drawable.ic_menu_add,
+android.R.drawable.ic_menu_send
 };
 
 private ListView navList;
@@ -81,6 +84,14 @@
 break;
 case R.string.zero_free_verbiage:
 return;
+case R.string.nav_item_send_feedback:
+// Will be stripped out in prod builds
+intent.setAction(Intent.ACTION_SENDTO);
+// Will be moved to a better email address at some point
+// FIXME: Have build info here, perhaps? We can't access it 
anywhere yet
+
intent.setData(Uri.parse(mailto:yuvipa...@wikimedia.org?subject=Android App 
Feedback));
+startActivity(intent);
+break;
 default:
 throw new RuntimeException(Unknown ID clicked!);
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/117323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80ca683115e7454d7cded126cb3223d5ba08ad52
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda yuvipa...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add 'Send Feedback' iten to left nav - change (apps...wikipedia)

2014-03-06 Thread Brion VIBBER (Code Review) 
Brion VIBBER has submitted this change and it was merged.

Change subject: Add 'Send Feedback' iten to left nav
..


Add 'Send Feedback' iten to left nav

Will be stripped out before market release.

Change-Id: I80ca683115e7454d7cded126cb3223d5ba08ad52
---
M wikipedia/res/values/strings.xml
M wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
2 files changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml
index 7b3fc22..ca74299 100644
--- a/wikipedia/res/values/strings.xml
+++ b/wikipedia/res/values/strings.xml
@@ -111,4 +111,5 @@
 string name=edit_preview_fetching_dialog_messageFetching 
preview.../string
 string name=edit_preview_activity_titlePreview edit/string
 string name=create_account_logging_inLogging in.../string
+string name=nav_item_send_feedbackSend feedback/string
 /resources
diff --git a/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java 
b/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
index 0cb4a8b..9823705 100644
--- a/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
@@ -3,6 +3,7 @@
 import android.app.*;
 import android.content.*;
 import android.graphics.*;
+import android.net.*;
 import android.os.*;
 import android.support.v4.app.Fragment;
 import android.view.*;
@@ -18,13 +19,15 @@
 R.string.nav_item_saved_pages,
 R.string.nav_item_preferences,
 R.string.nav_item_login,
+R.string.nav_item_send_feedback,
 R.string.zero_free_verbiage
 };
 private static final int[] ACTION_ITEM_IMAGES = {
 android.R.drawable.ic_menu_recent_history,
 android.R.drawable.ic_menu_save,
 android.R.drawable.ic_menu_preferences,
-android.R.drawable.ic_menu_add
+android.R.drawable.ic_menu_add,
+android.R.drawable.ic_menu_send
 };
 
 private ListView navList;
@@ -81,6 +84,14 @@
 break;
 case R.string.zero_free_verbiage:
 return;
+case R.string.nav_item_send_feedback:
+// Will be stripped out in prod builds
+intent.setAction(Intent.ACTION_SENDTO);
+// Will be moved to a better email address at some point
+// FIXME: Have build info here, perhaps? We can't access it 
anywhere yet
+
intent.setData(Uri.parse(mailto:yuvipa...@wikimedia.org?subject=Android App 
Feedback));
+startActivity(intent);
+break;
 default:
 throw new RuntimeException(Unknown ID clicked!);
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/117323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80ca683115e7454d7cded126cb3223d5ba08ad52
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda yuvipa...@gmail.com
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits