[MediaWiki-commits] [Gerrit] Add a step for the "view page" link - change (mediawiki...ContentTranslation)

2014-01-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add a step for the "view page" link
..


Add a step for the "view page" link

Change-Id: Iaa5cffefbd7a4b44966152518f6400fadf4d67d3
---
M tests/browser/features/step_definitions/special_content_translation_steps.rb
M tests/browser/features/support/pages/content_translation_page.rb
2 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  KartikMistry: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/tests/browser/features/step_definitions/special_content_translation_steps.rb 
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
index 1fa3568..cfaacfd 100644
--- 
a/tests/browser/features/step_definitions/special_content_translation_steps.rb
+++ 
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
@@ -95,5 +95,6 @@
 end
 
 Then(/^the "view page" link points to the page "(.*?)" on the same wiki$/) do 
|source_page|
-   pending # express the regexp above with the code you wish you had
+   source_page_in_url = source_page.gsub(" ", "_")
+   on(ContentTranslationPage).view_page_element.attribute("href").should 
match(/#{source_page_in_url}$/)
 end
diff --git a/tests/browser/features/support/pages/content_translation_page.rb 
b/tests/browser/features/support/pages/content_translation_page.rb
index e573f65..1c8c07e 100644
--- a/tests/browser/features/support/pages/content_translation_page.rb
+++ b/tests/browser/features/support/pages/content_translation_page.rb
@@ -3,6 +3,8 @@
include URL
page_url URL.url("Special:ContentTranslation")
 
+   a(:view_page, class: "view-page")
+
button(:publish_translation, class: "publish-translation")
 
div(:source_column, class: "source")

-- 
To view, visit https://gerrit.wikimedia.org/r/106245
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa5cffefbd7a4b44966152518f6400fadf4d67d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 
Gerrit-Reviewer: Amire80 
Gerrit-Reviewer: KartikMistry 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add a step for the "view page" link - change (mediawiki...ContentTranslation)

2014-01-08 Thread Amire80 (Code Review) 
Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/106245


Change subject: Add a step for the "view page" link
..

Add a step for the "view page" link

Change-Id: Iaa5cffefbd7a4b44966152518f6400fadf4d67d3
---
M tests/browser/features/step_definitions/special_content_translation_steps.rb
M tests/browser/features/support/pages/content_translation_page.rb
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/45/106245/1

diff --git 
a/tests/browser/features/step_definitions/special_content_translation_steps.rb 
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
index 1fa3568..cfaacfd 100644
--- 
a/tests/browser/features/step_definitions/special_content_translation_steps.rb
+++ 
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
@@ -95,5 +95,6 @@
 end
 
 Then(/^the "view page" link points to the page "(.*?)" on the same wiki$/) do 
|source_page|
-   pending # express the regexp above with the code you wish you had
+   source_page_in_url = source_page.gsub(" ", "_")
+   on(ContentTranslationPage).view_page_element.attribute("href").should 
match(/#{source_page_in_url}$/)
 end
diff --git a/tests/browser/features/support/pages/content_translation_page.rb 
b/tests/browser/features/support/pages/content_translation_page.rb
index e573f65..1c8c07e 100644
--- a/tests/browser/features/support/pages/content_translation_page.rb
+++ b/tests/browser/features/support/pages/content_translation_page.rb
@@ -3,6 +3,8 @@
include URL
page_url URL.url("Special:ContentTranslation")
 
+   a(:view_page, class: "view-page")
+
button(:publish_translation, class: "publish-translation")
 
div(:source_column, class: "source")

-- 
To view, visit https://gerrit.wikimedia.org/r/106245
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa5cffefbd7a4b44966152518f6400fadf4d67d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits