[MediaWiki-commits] [Gerrit] Add memkeys to role::memcached - change (operations/puppet)

2014-05-21 Thread Faidon Liambotis (Code Review) 
Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/134612

Change subject: Add memkeys to role::memcached
..

Add memkeys to role::memcached

memkeys is a top-like utility for memcache keys by Tumblr, ported to C++
from a Ruby utility by Etsy. It's useful to debug memcache regressions.

Try it on memcached servers, for now, although eventually it could be
also very useful in appservers themselves as they would have the full
view of all keys.

Change-Id: Ida4b76470871bc1911d878fea44fc71bda58e004
---
M manifests/role/memcached.pp
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/12/134612/1

diff --git a/manifests/role/memcached.pp b/manifests/role/memcached.pp
index b91e820..04ba68a 100644
--- a/manifests/role/memcached.pp
+++ b/manifests/role/memcached.pp
@@ -26,4 +26,7 @@
}
}
 
+   package { 'memkeys':
+   ensure = present,
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/134612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida4b76470871bc1911d878fea44fc71bda58e004
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis fai...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add memkeys to role::memcached - change (operations/puppet)

2014-05-21 Thread Faidon Liambotis (Code Review) 
Faidon Liambotis has submitted this change and it was merged.

Change subject: Add memkeys to role::memcached
..


Add memkeys to role::memcached

memkeys is a top-like utility for memcache keys by Tumblr, ported to C++
from a Ruby utility by Etsy. It's useful to debug memcache regressions.

Try it on memcached servers, for now, although eventually it could be
also very useful in appservers themselves as they would have the full
view of all keys.

Change-Id: Ida4b76470871bc1911d878fea44fc71bda58e004
---
M manifests/role/memcached.pp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Faidon Liambotis: Verified; Looks good to me, approved



diff --git a/manifests/role/memcached.pp b/manifests/role/memcached.pp
index b91e820..04ba68a 100644
--- a/manifests/role/memcached.pp
+++ b/manifests/role/memcached.pp
@@ -26,4 +26,7 @@
}
}
 
+   package { 'memkeys':
+   ensure = present,
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/134612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida4b76470871bc1911d878fea44fc71bda58e004
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis fai...@wikimedia.org
Gerrit-Reviewer: Faidon Liambotis fai...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits