[MediaWiki-commits] [Gerrit] Add missing fail-safe to counter calculation in statementview - change (mediawiki...Wikibase)

2015-07-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add missing fail-safe to counter calculation in statementview
..


Add missing fail-safe to counter calculation in statementview

This is split from I9444ae5. This adds a missing fail-safe. That's
all. Note that the private variable can be null. All other places in
the code already check this.

Bug: T87759
Change-Id: I54cf4c0333c9744ccacf11ddd833fbd7843541ff
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js 
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index ba90614..a452a84 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -608,8 +608,13 @@
 * @private
 */
_drawReferencesCounter: function() {
-   var numberOfValues = 
this._referencesListview.nonEmptyItems().length,
+   var numberOfValues = 0,
+   numberOfPendingValues = 0;
+
+   if( this._referencesListview ) {
+   numberOfValues = 
this._referencesListview.nonEmptyItems().length;
numberOfPendingValues = 
this._referencesListview.items().length - numberOfValues;
+   }
 
// build a nice counter, displaying fixed and pending values:
var $counterMsg = wb.utilities.ui.buildPendingCounter(

-- 
To view, visit https://gerrit.wikimedia.org/r/223548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54cf4c0333c9744ccacf11ddd833fbd7843541ff
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) thiemo.maet...@wikimedia.de
Gerrit-Reviewer: Jonas Kress (WMDE) jonas.kr...@wikimedia.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add missing fail-safe to counter calculation in statementview - change (mediawiki...Wikibase)

2015-07-08 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/223548

Change subject: Add missing fail-safe to counter calculation in statementview
..

Add missing fail-safe to counter calculation in statementview

This is split from I9444ae5. This adds a missing fail-safe. That's
all. Note that the private variable can be null. All other places in
the code already check this.

Bug: T87759
Change-Id: I54cf4c0333c9744ccacf11ddd833fbd7843541ff
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/48/223548/1

diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js 
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index ba90614..a452a84 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -608,8 +608,13 @@
 * @private
 */
_drawReferencesCounter: function() {
-   var numberOfValues = 
this._referencesListview.nonEmptyItems().length,
+   var numberOfValues = 0,
+   numberOfPendingValues = 0;
+
+   if( this._referencesListview ) {
+   numberOfValues = 
this._referencesListview.nonEmptyItems().length;
numberOfPendingValues = 
this._referencesListview.items().length - numberOfValues;
+   }
 
// build a nice counter, displaying fixed and pending values:
var $counterMsg = wb.utilities.ui.buildPendingCounter(

-- 
To view, visit https://gerrit.wikimedia.org/r/223548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54cf4c0333c9744ccacf11ddd833fbd7843541ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) thiemo.maet...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits