[MediaWiki-commits] [Gerrit] Add space between classes in HTMLButtonField - change (mediawiki/core)

2015-08-27 Thread Ricordisamoa (Code Review) 
Ricordisamoa has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/234277

Change subject: Add space between classes in HTMLButtonField
..

Add space between classes in HTMLButtonField

Classes such as 'wb-input-buttonmw-ui-button' were being generated
when $wgUseMediaWikiUIEverywhere = true, see:
https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests-mysql-hhvm/4217/console

Change-Id: If40b712ffb8e31d27380bf481333eecb7b95f9de
---
M includes/htmlform/HTMLButtonField.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/77/234277/1

diff --git a/includes/htmlform/HTMLButtonField.php 
b/includes/htmlform/HTMLButtonField.php
index b0b08a6..56a23ad 100644
--- a/includes/htmlform/HTMLButtonField.php
+++ b/includes/htmlform/HTMLButtonField.php
@@ -28,7 +28,7 @@
) {
$prefix = 'mw-ui-';
// add mw-ui-button separately, so the descriptor 
doesn't need to set it
-   $flags .= $prefix.'button';
+   $flags .= ' ' . $prefix.'button';
}
foreach ( $this-mFlags as $flag ) {
$flags .= ' ' . $prefix . $flag;

-- 
To view, visit https://gerrit.wikimedia.org/r/234277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If40b712ffb8e31d27380bf481333eecb7b95f9de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa ricordisa...@openmailbox.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add space between classes in HTMLButtonField - change (mediawiki/core)

2015-08-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Add space between classes in HTMLButtonField
..


Add space between classes in HTMLButtonField

Classes such as 'wb-input-buttonmw-ui-button' were being generated
when $wgUseMediaWikiUIEverywhere = true, see:
https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests-mysql-hhvm/4217/console

Change-Id: If40b712ffb8e31d27380bf481333eecb7b95f9de
---
M includes/htmlform/HTMLButtonField.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/htmlform/HTMLButtonField.php 
b/includes/htmlform/HTMLButtonField.php
index b0b08a6..56a23ad 100644
--- a/includes/htmlform/HTMLButtonField.php
+++ b/includes/htmlform/HTMLButtonField.php
@@ -28,7 +28,7 @@
) {
$prefix = 'mw-ui-';
// add mw-ui-button separately, so the descriptor 
doesn't need to set it
-   $flags .= $prefix.'button';
+   $flags .= ' ' . $prefix.'button';
}
foreach ( $this-mFlags as $flag ) {
$flags .= ' ' . $prefix . $flag;

-- 
To view, visit https://gerrit.wikimedia.org/r/234277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If40b712ffb8e31d27380bf481333eecb7b95f9de
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa ricordisa...@openmailbox.org
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Daniel Friesen dan...@nadir-seen-fire.com
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Jonas Kress (WMDE) jonas.kr...@wikimedia.de
Gerrit-Reviewer: Umherirrender umherirrender_de...@web.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits