[MediaWiki-commits] [Gerrit] Added a bunch of docs and stub classes - change (mediawiki...Wikibase)

2013-02-26 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/50935


Change subject: Added a bunch of docs and stub classes
..

Added a bunch of docs and stub classes

Change-Id: Icaddb6ab2b00bcf16639be7b47b4a937fbdec088
---
M repo/includes/Database/FieldDefinition.php
M repo/includes/Database/MediaWikiQueryInterface.php
M repo/includes/Database/QueryInterface.php
M repo/includes/Database/TableBuilder.php
M repo/includes/Database/TableDefinition.php
M repo/includes/Query/QueryEngine.php
M repo/includes/Query/QueryEngineResult.php
M repo/includes/Query/QueryStore.php
A repo/includes/Query/SQLStore/DataValueHandler.php
A repo/includes/Query/SQLStore/Engine.php
D repo/includes/Query/SQLStore/QueryEngine.php
M repo/includes/Query/SQLStore/Setup.php
M repo/includes/Query/SQLStore/Store.php
13 files changed, 263 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/35/50935/1

diff --git a/repo/includes/Database/FieldDefinition.php 
b/repo/includes/Database/FieldDefinition.php
index 01f3024..e1d3301 100644
--- a/repo/includes/Database/FieldDefinition.php
+++ b/repo/includes/Database/FieldDefinition.php
@@ -22,7 +22,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
@@ -33,49 +33,49 @@
 class FieldDefinition implements \Immutable {
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var string
 */
private $name;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var string
 */
private $type;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var mixed
 */
private $default;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var string|null
 */
private $attributes;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var boolean
 */
private $null;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var string|null
 */
private $index;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var boolean
 */
diff --git a/repo/includes/Database/MediaWikiQueryInterface.php 
b/repo/includes/Database/MediaWikiQueryInterface.php
index 64f0469..a4a5e6d 100644
--- a/repo/includes/Database/MediaWikiQueryInterface.php
+++ b/repo/includes/Database/MediaWikiQueryInterface.php
@@ -23,7 +23,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
diff --git a/repo/includes/Database/QueryInterface.php 
b/repo/includes/Database/QueryInterface.php
index 56f10c9..7619f9b 100644
--- a/repo/includes/Database/QueryInterface.php
+++ b/repo/includes/Database/QueryInterface.php
@@ -20,7 +20,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
diff --git a/repo/includes/Database/TableBuilder.php 
b/repo/includes/Database/TableBuilder.php
index 5a819dd..490d7e9 100644
--- a/repo/includes/Database/TableBuilder.php
+++ b/repo/includes/Database/TableBuilder.php
@@ -22,7 +22,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
@@ -33,14 +33,14 @@
 class TableBuilder {
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var QueryInterface
 */
private $db;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var MessageReporter|null
 */
@@ -49,7 +49,7 @@
/**
 * Constructor.
 *
-* @since 0.4
+* @since wd.db
 *
 * @param QueryInterface $queryInterface
 * @param MessageReporter|null $messageReporter
@@ -60,7 +60,7 @@
}
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @param string $message
 */
@@ -73,7 +73,7 @@
/**
 * Creates a table if it does not exist yet.
 *
-* @since 0.4
+* @since wd.db
 *
 * @param TableDefinition $table
 */
diff --git a/repo/includes/Database/TableDefinition.php 
b/repo/includes/Database/TableDefinition.php
index d1ccce9..37e9006 100644
--- a/repo/includes/Database/TableDefinition.php
+++ b/repo/includes/Database/TableDefinition.php
@@ -22,7 +22,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * 

[MediaWiki-commits] [Gerrit] Added a bunch of docs and stub classes - change (mediawiki...Wikibase)

2013-02-26 Thread John Erling Blad (Code Review)
John Erling Blad has submitted this change and it was merged.

Change subject: Added a bunch of docs and stub classes
..


Added a bunch of docs and stub classes

Change-Id: Icaddb6ab2b00bcf16639be7b47b4a937fbdec088
---
M repo/includes/Database/FieldDefinition.php
M repo/includes/Database/MediaWikiQueryInterface.php
M repo/includes/Database/QueryInterface.php
M repo/includes/Database/TableBuilder.php
M repo/includes/Database/TableDefinition.php
M repo/includes/Query/QueryEngine.php
M repo/includes/Query/QueryEngineResult.php
M repo/includes/Query/QueryStore.php
A repo/includes/Query/SQLStore/DataValueHandler.php
A repo/includes/Query/SQLStore/Engine.php
D repo/includes/Query/SQLStore/QueryEngine.php
M repo/includes/Query/SQLStore/Setup.php
M repo/includes/Query/SQLStore/Store.php
13 files changed, 263 insertions(+), 54 deletions(-)

Approvals:
  John Erling Blad: Verified; Looks good to me, approved



diff --git a/repo/includes/Database/FieldDefinition.php 
b/repo/includes/Database/FieldDefinition.php
index 01f3024..e1d3301 100644
--- a/repo/includes/Database/FieldDefinition.php
+++ b/repo/includes/Database/FieldDefinition.php
@@ -22,7 +22,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
@@ -33,49 +33,49 @@
 class FieldDefinition implements \Immutable {
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var string
 */
private $name;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var string
 */
private $type;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var mixed
 */
private $default;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var string|null
 */
private $attributes;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var boolean
 */
private $null;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var string|null
 */
private $index;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var boolean
 */
diff --git a/repo/includes/Database/MediaWikiQueryInterface.php 
b/repo/includes/Database/MediaWikiQueryInterface.php
index 64f0469..a4a5e6d 100644
--- a/repo/includes/Database/MediaWikiQueryInterface.php
+++ b/repo/includes/Database/MediaWikiQueryInterface.php
@@ -23,7 +23,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
diff --git a/repo/includes/Database/QueryInterface.php 
b/repo/includes/Database/QueryInterface.php
index 56f10c9..7619f9b 100644
--- a/repo/includes/Database/QueryInterface.php
+++ b/repo/includes/Database/QueryInterface.php
@@ -20,7 +20,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
diff --git a/repo/includes/Database/TableBuilder.php 
b/repo/includes/Database/TableBuilder.php
index 5a819dd..490d7e9 100644
--- a/repo/includes/Database/TableBuilder.php
+++ b/repo/includes/Database/TableBuilder.php
@@ -22,7 +22,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
@@ -33,14 +33,14 @@
 class TableBuilder {
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var QueryInterface
 */
private $db;
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @var MessageReporter|null
 */
@@ -49,7 +49,7 @@
/**
 * Constructor.
 *
-* @since 0.4
+* @since wd.db
 *
 * @param QueryInterface $queryInterface
 * @param MessageReporter|null $messageReporter
@@ -60,7 +60,7 @@
}
 
/**
-* @since 0.4
+* @since wd.db
 *
 * @param string $message
 */
@@ -73,7 +73,7 @@
/**
 * Creates a table if it does not exist yet.
 *
-* @since 0.4
+* @since wd.db
 *
 * @param TableDefinition $table
 */
diff --git a/repo/includes/Database/TableDefinition.php 
b/repo/includes/Database/TableDefinition.php
index d1ccce9..37e9006 100644
--- a/repo/includes/Database/TableDefinition.php
+++ b/repo/includes/Database/TableDefinition.php
@@ -22,7 +22,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  * http://www.gnu.org/copyleft/gpl.html
  *
- * @since 0.4
+ * @since wd.db
  *
  * @file
  * @ingroup WikibaseRepo
@@