[MediaWiki-commits] [Gerrit] Added check if object is present - change (mediawiki...BlueSpiceExtensions)

2015-11-25 Thread Pwirth (Code Review) 
Pwirth has submitted this change and it was merged.

Change subject: Added check if object is present
..


Added check if object is present

If tiny is not yet loaded, SaferEdit still tries to access a property.
Added a check and if not loaded, reading the isDirty property is
skipped.

Change-Id: I7f07ec5305fe63771a508b8c7706c05a9db1715c
---
M SaferEdit/resources/bluespice.SaferEdit.editmode.js
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Pwirth: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SaferEdit/resources/bluespice.SaferEdit.editmode.js 
b/SaferEdit/resources/bluespice.SaferEdit.editmode.js
index fccc07f..361d360 100644
--- a/SaferEdit/resources/bluespice.SaferEdit.editmode.js
+++ b/SaferEdit/resources/bluespice.SaferEdit.editmode.js
@@ -141,6 +141,9 @@
},
hasUnsavedChanges: function ( mode ) {
if ( typeof ( VisualEditor ) !== "undefined" && 
VisualEditor._editorMode === "tiny" ) {
+   if (!tinyMCE.activeEditor ) {
+   return null;
+   }
BsSaferEditEditMode.isUnsaved = 
tinyMCE.activeEditor.isDirty();
return BsSaferEditEditMode.isUnsaved;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/255398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f07ec5305fe63771a508b8c7706c05a9db1715c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Added check if object is present - change (mediawiki...BlueSpiceExtensions)

2015-11-25 Thread Mglaser (Code Review) 
Mglaser has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/255398

Change subject: Added check if object is present
..

Added check if object is present

If tiny is not yet loaded, SaferEdit still tries to access a property.
Added a check and if not loaded, reading the isDirty property is
skipped.

Change-Id: I7f07ec5305fe63771a508b8c7706c05a9db1715c
---
M SaferEdit/resources/bluespice.SaferEdit.editmode.js
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/98/255398/1

diff --git a/SaferEdit/resources/bluespice.SaferEdit.editmode.js 
b/SaferEdit/resources/bluespice.SaferEdit.editmode.js
index fccc07f..361d360 100644
--- a/SaferEdit/resources/bluespice.SaferEdit.editmode.js
+++ b/SaferEdit/resources/bluespice.SaferEdit.editmode.js
@@ -141,6 +141,9 @@
},
hasUnsavedChanges: function ( mode ) {
if ( typeof ( VisualEditor ) !== "undefined" && 
VisualEditor._editorMode === "tiny" ) {
+   if (!tinyMCE.activeEditor ) {
+   return null;
+   }
BsSaferEditEditMode.isUnsaved = 
tinyMCE.activeEditor.isDirty();
return BsSaferEditEditMode.isUnsaved;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/255398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f07ec5305fe63771a508b8c7706c05a9db1715c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Mglaser 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits