[MediaWiki-commits] [Gerrit] Allocation API Now works in XML - change (mediawiki...CentralNotice)

2013-03-07 Thread Mwalker (Code Review)
Mwalker has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/52763


Change subject: Allocation API Now works in XML
..

Allocation API Now works in XML

Needed to make an extra call to let the XML parser in the API
know how to deal with enumerated arrays.

Bug: 45884
Change-Id: Iafef5e8233bd3c46aafb440983dd90807fb26b72
---
M api/ApiCentralNoticeAllocations.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/63/52763/1

diff --git a/api/ApiCentralNoticeAllocations.php 
b/api/ApiCentralNoticeAllocations.php
index 1d668bb..a1ec2a3 100644
--- a/api/ApiCentralNoticeAllocations.php
+++ b/api/ApiCentralNoticeAllocations.php
@@ -49,6 +49,7 @@
$params['minimal']
);
 
+   $result-setIndexedTagName( $bannerList, 'BannerAllocation' );
$result-addValue( $this-getModuleName(), 'banners', 
$bannerList );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/52763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafef5e8233bd3c46aafb440983dd90807fb26b72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker mwal...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Allocation API Now works in XML - change (mediawiki...CentralNotice)

2013-03-07 Thread Pgehres (Code Review)
Pgehres has submitted this change and it was merged.

Change subject: Allocation API Now works in XML
..


Allocation API Now works in XML

Needed to make an extra call to let the XML parser in the API
know how to deal with enumerated arrays.

Bug: 45884
Change-Id: Iafef5e8233bd3c46aafb440983dd90807fb26b72
---
M api/ApiCentralNoticeAllocations.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Pgehres: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/api/ApiCentralNoticeAllocations.php 
b/api/ApiCentralNoticeAllocations.php
index 1d668bb..a1ec2a3 100644
--- a/api/ApiCentralNoticeAllocations.php
+++ b/api/ApiCentralNoticeAllocations.php
@@ -49,6 +49,7 @@
$params['minimal']
);
 
+   $result-setIndexedTagName( $bannerList, 'BannerAllocation' );
$result-addValue( $this-getModuleName(), 'banners', 
$bannerList );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/52763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafef5e8233bd3c46aafb440983dd90807fb26b72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker mwal...@wikimedia.org
Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits