[MediaWiki-commits] [Gerrit] Another refactoring fix - change (mediawiki...SemanticForms)

2016-06-21 Thread Yaron Koren (Code Review) 
Yaron Koren has submitted this change and it was merged.

Change subject: Another refactoring fix
..


Another refactoring fix

Change-Id: Id4026d401ba7546c3e6e557f26653bdeeb86c390
---
M includes/SF_FormField.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Checked; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/SF_FormField.php b/includes/SF_FormField.php
index b1f5ed6..b83157f 100644
--- a/includes/SF_FormField.php
+++ b/includes/SF_FormField.php
@@ -441,9 +441,9 @@
// this should be replaced with 
an input type neutral way of
// figuring out if this scalar 
input type is a list
if ( $this->mInputType == 
"tokens" ) {
-   $is_list = true;
+   $this->mIsList = true;
}
-   if ( $is_list ) {
+   if ( $this->mIsList ) {
$cur_values = 
array_map( 'trim', explode( $delimiter, $field_query_val ) );
foreach ( $cur_values 
as $key => $val ) {

$cur_values[$key] = $this->labelToValue( $val );

-- 
To view, visit https://gerrit.wikimedia.org/r/295386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4026d401ba7546c3e6e557f26653bdeeb86c390
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Another refactoring fix - change (mediawiki...SemanticForms)

2016-06-21 Thread Yaron Koren (Code Review) 
Yaron Koren has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/295386

Change subject: Another refactoring fix
..

Another refactoring fix

Change-Id: Id4026d401ba7546c3e6e557f26653bdeeb86c390
---
M includes/SF_FormField.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms 
refs/changes/86/295386/1

diff --git a/includes/SF_FormField.php b/includes/SF_FormField.php
index b1f5ed6..b83157f 100644
--- a/includes/SF_FormField.php
+++ b/includes/SF_FormField.php
@@ -441,9 +441,9 @@
// this should be replaced with 
an input type neutral way of
// figuring out if this scalar 
input type is a list
if ( $this->mInputType == 
"tokens" ) {
-   $is_list = true;
+   $this->mIsList = true;
}
-   if ( $is_list ) {
+   if ( $this->mIsList ) {
$cur_values = 
array_map( 'trim', explode( $delimiter, $field_query_val ) );
foreach ( $cur_values 
as $key => $val ) {

$cur_values[$key] = $this->labelToValue( $val );

-- 
To view, visit https://gerrit.wikimedia.org/r/295386
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4026d401ba7546c3e6e557f26653bdeeb86c390
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits