[MediaWiki-commits] [Gerrit] Apply the nomobile class - change (mediawiki...FlaggedRevs)

2016-02-17 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Apply the nomobile class
..


Apply the nomobile class

The ext.flaggedRevs.basic is not currently targeted at mobile and looking
at it, there is no need for it to be.

Unfortunately this means the banner in FlaggablePageview is visible in mobile
browsers taking up real estate.

This generic solution allows the hiding of this banner at mobile resolutions

Bug: T119344
Change-Id: I8c718394f870812ec946dffb2b89474757c64b08
---
M frontend/FlaggablePageView.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 5eb51a5..6746776 100755
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -380,7 +380,7 @@
}
# Wrap tag contents in a div
if ( $tag != '' ) {
-   $css = "{$tagClass} plainlinks noprint";
+   $css = "{$tagClass} plainlinks noprint nomobile";
$notice = "{$tag}\n";
$this->reviewNotice .= $notice;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/271424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c718394f870812ec946dffb2b89474757c64b08
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Apply the nomobile class - change (mediawiki...FlaggedRevs)

2016-02-17 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/271424

Change subject: Apply the nomobile class
..

Apply the nomobile class

The ext.flaggedRevs.basic is not currently targeted at mobile and looking
at it, there is no need for it to be.

Unfortunately this means the banner in FlaggablePageview is visible in mobile
browsers taking up real estate.

This generic solution allows the hiding of this banner at mobile resolutions

Change-Id: I8c718394f870812ec946dffb2b89474757c64b08
---
M frontend/FlaggablePageView.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/24/271424/1

diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 5eb51a5..6746776 100755
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -380,7 +380,7 @@
}
# Wrap tag contents in a div
if ( $tag != '' ) {
-   $css = "{$tagClass} plainlinks noprint";
+   $css = "{$tagClass} plainlinks noprint nomobile";
$notice = "{$tag}\n";
$this->reviewNotice .= $notice;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/271424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c718394f870812ec946dffb2b89474757c64b08
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits