[MediaWiki-commits] [Gerrit] Avoid "leaked window" errors by dismissing popups, not just ... - change (apps...wikipedia)

2014-02-24 Thread Yuvipanda (Code Review) 
Yuvipanda has submitted this change and it was merged.

Change subject: Avoid "leaked window" errors by dismissing popups, not just 
hiding them, on success
..


Avoid "leaked window" errors by dismissing popups, not just hiding them, on 
success

Change-Id: I45a2dc6d73f5b0891fea5f1124394d286f14d314
---
M wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
M wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yuvipanda: Verified; Looks good to me, approved



diff --git 
a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java 
b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
index a9cc961..64a0f8c 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
@@ -68,7 +68,7 @@
 public void onFinish(String result) {
 displayPreview(result);
 previewHTML = result;
-dialog.hide();
+dialog.dismiss();
 }
 }.execute();
 }
diff --git 
a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java 
b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
index 705d0d0..0be9a89 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
@@ -181,7 +181,7 @@
 @Override
 public void onFinish(EditingResult result) {
 if (result instanceof SuccessEditResult) {
-progressDialog.hide();
+progressDialog.dismiss();
 setResult(EditHandler.RESULT_REFRESH_PAGE);
 Toast.makeText(EditSectionActivity.this, 
R.string.edit_saved_successfully, Toast.LENGTH_LONG).show();
 Utils.hideSoftKeyboard(EditSectionActivity.this);

-- 
To view, visit https://gerrit.wikimedia.org/r/115317
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I45a2dc6d73f5b0891fea5f1124394d286f14d314
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 
Gerrit-Reviewer: Yuvipanda 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Avoid "leaked window" errors by dismissing popups, not just ... - change (apps...wikipedia)

2014-02-24 Thread Brion VIBBER (Code Review) 
Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/115317

Change subject: Avoid "leaked window" errors by dismissing popups, not just 
hiding them, on success
..

Avoid "leaked window" errors by dismissing popups, not just hiding them, on 
success

Change-Id: I45a2dc6d73f5b0891fea5f1124394d286f14d314
---
M wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
M wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/17/115317/1

diff --git 
a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java 
b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
index a9cc961..64a0f8c 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
@@ -68,7 +68,7 @@
 public void onFinish(String result) {
 displayPreview(result);
 previewHTML = result;
-dialog.hide();
+dialog.dismiss();
 }
 }.execute();
 }
diff --git 
a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java 
b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
index 705d0d0..0be9a89 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
@@ -181,7 +181,7 @@
 @Override
 public void onFinish(EditingResult result) {
 if (result instanceof SuccessEditResult) {
-progressDialog.hide();
+progressDialog.dismiss();
 setResult(EditHandler.RESULT_REFRESH_PAGE);
 Toast.makeText(EditSectionActivity.this, 
R.string.edit_saved_successfully, Toast.LENGTH_LONG).show();
 Utils.hideSoftKeyboard(EditSectionActivity.this);

-- 
To view, visit https://gerrit.wikimedia.org/r/115317
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45a2dc6d73f5b0891fea5f1124394d286f14d314
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits