[MediaWiki-commits] [Gerrit] Avoids to fail if Image::transform returns false - change (mediawiki...ProofreadPage)

2016-06-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Avoids to fail if Image::transform returns false
..


Avoids to fail if Image::transform returns false

Change-Id: I183a393f1b20d29aa8e764db75f0804f2fe4745f
---
M includes/page/ProofreadPagePage.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Tpt: Looks good to me, approved
  Jforrester: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/page/ProofreadPagePage.php 
b/includes/page/ProofreadPagePage.php
index 2a4581c..7516e64 100644
--- a/includes/page/ProofreadPagePage.php
+++ b/includes/page/ProofreadPagePage.php
@@ -207,6 +207,9 @@
return null;
}
$thumbnail = $image->transform( $transformAttributes );
+   if ( !$thumbnail ) {
+   return null;
+   }
return $thumbnail->toHtml( $options );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/295531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I183a393f1b20d29aa8e764db75f0804f2fe4745f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt 
Gerrit-Reviewer: GOIII 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Phe 
Gerrit-Reviewer: Tpt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Avoids to fail if Image::transform returns false - change (mediawiki...ProofreadPage)

2016-06-22 Thread Tpt (Code Review) 
Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/295531

Change subject: Avoids to fail if Image::transform returns false
..

Avoids to fail if Image::transform returns false

Change-Id: I183a393f1b20d29aa8e764db75f0804f2fe4745f
---
M includes/page/ProofreadPagePage.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/31/295531/1

diff --git a/includes/page/ProofreadPagePage.php 
b/includes/page/ProofreadPagePage.php
index 2a4581c..7516e64 100644
--- a/includes/page/ProofreadPagePage.php
+++ b/includes/page/ProofreadPagePage.php
@@ -207,6 +207,9 @@
return null;
}
$thumbnail = $image->transform( $transformAttributes );
+   if ( !$thumbnail ) {
+   return null;
+   }
return $thumbnail->toHtml( $options );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/295531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I183a393f1b20d29aa8e764db75f0804f2fe4745f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits