[MediaWiki-commits] [Gerrit] Back to weird title - change (mediawiki...Wikibase)

2013-03-07 Thread John Erling Blad (Code Review)
John Erling Blad has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/52629


Change subject: Back to weird title
..

Back to weird title

In some part of the extension we are using words that simply don't
fit what we are doing, but some of the weird wording has stuck
somehow. In ItemByTitle we are really talking about a sitelink to
an external site, with a pair of site id and a title on the external
site, not about a single title. The last would be a local page.

Change-Id: I40f69948036cec605dc0aa342084d884a003dd50
---
M repo/Wikibase.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/29/52629/1

diff --git a/repo/Wikibase.i18n.php b/repo/Wikibase.i18n.php
index 9c3435f..4ba5532 100644
--- a/repo/Wikibase.i18n.php
+++ b/repo/Wikibase.i18n.php
@@ -113,7 +113,7 @@
'wikibase-itemlink-title' = '$1 | $2',
 
// Special pages
-   'special-itembytitle' = 'Item by sitelink',
+   'special-itembytitle' = 'Item by title',
'wikibase-itembytitle-lookup-fieldset' = 'Search for items by site and 
title',
'wikibase-itembytitle-lookup-site' = 'Site:',
'wikibase-itembytitle-lookup-page' = 'Page:',

-- 
To view, visit https://gerrit.wikimedia.org/r/52629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I40f69948036cec605dc0aa342084d884a003dd50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: John Erling Blad john.b...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Back to weird title - change (mediawiki...Wikibase)

2013-03-07 Thread John Erling Blad (Code Review)
John Erling Blad has submitted this change and it was merged.

Change subject: Back to weird title
..


Back to weird title

In some part of the extension we are using words that simply don't
fit what we are doing, but some of the weird wording has stuck
somehow. In ItemByTitle we are really talking about a sitelink to
an external site, with a pair of site id and a title on the external
site, not about a single title. The last would be a local page.

Change-Id: I40f69948036cec605dc0aa342084d884a003dd50
---
M repo/Wikibase.i18n.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  John Erling Blad: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/Wikibase.i18n.php b/repo/Wikibase.i18n.php
index 9c3435f..4ba5532 100644
--- a/repo/Wikibase.i18n.php
+++ b/repo/Wikibase.i18n.php
@@ -113,7 +113,7 @@
'wikibase-itemlink-title' = '$1 | $2',
 
// Special pages
-   'special-itembytitle' = 'Item by sitelink',
+   'special-itembytitle' = 'Item by title',
'wikibase-itembytitle-lookup-fieldset' = 'Search for items by site and 
title',
'wikibase-itembytitle-lookup-site' = 'Site:',
'wikibase-itembytitle-lookup-page' = 'Page:',

-- 
To view, visit https://gerrit.wikimedia.org/r/52629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40f69948036cec605dc0aa342084d884a003dd50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: John Erling Blad john.b...@wikimedia.de
Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits