[MediaWiki-commits] [Gerrit] Bump SaveTiming SCID to 12236257 - change (mediawiki...NavigationTiming)
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212223
Change subject: Bump SaveTiming SCID to 12236257
..
Bump SaveTiming SCID to 12236257
* 'duration' renamed to 'saveDuration' and marked as required.
Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
---
M NavigationTiming.php
M modules/ext.navigationTiming.js
2 files changed, 5 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming
refs/changes/23/212223/1
diff --git a/NavigationTiming.php b/NavigationTiming.php
index 2b4a8af..8111b22 100644
--- a/NavigationTiming.php
+++ b/NavigationTiming.php
@@ -54,7 +54,7 @@
}
$wgEventLoggingSchemas += array(
'NavigationTiming' = 10785754,
- 'SaveTiming' = 10785299,
+ 'SaveTiming' = 12236257,
);
$wgHooks[ 'BeforePageDisplay' ][] = function ( $out, $skin ) {
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 53d37f3..dec8229 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -172,8 +172,10 @@
}
navTiming = getNavTiming();
- if ( navTiming ) {
- mw.eventLog.logEvent( 'SaveTiming', { duration:
navTiming.responseStart } );
+ if ( navTiming navTiming.responseStart ) {
+ mw.eventLog.logEvent( 'SaveTiming', {
+ saveTiming: navTiming.responseStart
+ } );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/212223
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: wmf/1.26wmf5
Gerrit-Owner: Ori.livneh o...@wikimedia.org
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bump SaveTiming SCID to 12236257 - change (mediawiki...NavigationTiming)
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/21
Change subject: Bump SaveTiming SCID to 12236257
..
Bump SaveTiming SCID to 12236257
* 'duration' renamed to 'saveDuration' and marked as required.
Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
---
M NavigationTiming.php
M modules/ext.navigationTiming.js
2 files changed, 5 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming
refs/changes/22/21/1
diff --git a/NavigationTiming.php b/NavigationTiming.php
index 2b4a8af..8111b22 100644
--- a/NavigationTiming.php
+++ b/NavigationTiming.php
@@ -54,7 +54,7 @@
}
$wgEventLoggingSchemas += array(
'NavigationTiming' = 10785754,
- 'SaveTiming' = 10785299,
+ 'SaveTiming' = 12236257,
);
$wgHooks[ 'BeforePageDisplay' ][] = function ( $out, $skin ) {
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 53d37f3..dec8229 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -172,8 +172,10 @@
}
navTiming = getNavTiming();
- if ( navTiming ) {
- mw.eventLog.logEvent( 'SaveTiming', { duration:
navTiming.responseStart } );
+ if ( navTiming navTiming.responseStart ) {
+ mw.eventLog.logEvent( 'SaveTiming', {
+ saveTiming: navTiming.responseStart
+ } );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/21
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: wmf/1.26wmf6
Gerrit-Owner: Ori.livneh o...@wikimedia.org
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bump SaveTiming SCID to 12236257 - change (mediawiki...NavigationTiming)
Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/212221
Change subject: Bump SaveTiming SCID to 12236257
..
Bump SaveTiming SCID to 12236257
* 'duration' renamed to 'saveDuration' and marked as required.
Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
---
M NavigationTiming.php
M modules/ext.navigationTiming.js
2 files changed, 5 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming
refs/changes/21/212221/1
diff --git a/NavigationTiming.php b/NavigationTiming.php
index 2b4a8af..8111b22 100644
--- a/NavigationTiming.php
+++ b/NavigationTiming.php
@@ -54,7 +54,7 @@
}
$wgEventLoggingSchemas += array(
'NavigationTiming' = 10785754,
- 'SaveTiming' = 10785299,
+ 'SaveTiming' = 12236257,
);
$wgHooks[ 'BeforePageDisplay' ][] = function ( $out, $skin ) {
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 53d37f3..dec8229 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -172,8 +172,10 @@
}
navTiming = getNavTiming();
- if ( navTiming ) {
- mw.eventLog.logEvent( 'SaveTiming', { duration:
navTiming.responseStart } );
+ if ( navTiming navTiming.responseStart ) {
+ mw.eventLog.logEvent( 'SaveTiming', {
+ saveTiming: navTiming.responseStart
+ } );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/212221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh o...@wikimedia.org
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bump SaveTiming SCID to 12236257 - change (mediawiki...NavigationTiming)
jenkins-bot has submitted this change and it was merged.
Change subject: Bump SaveTiming SCID to 12236257
..
Bump SaveTiming SCID to 12236257
* 'duration' renamed to 'saveDuration' and marked as required.
Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
---
M NavigationTiming.php
M modules/ext.navigationTiming.js
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/NavigationTiming.php b/NavigationTiming.php
index 2b4a8af..8111b22 100644
--- a/NavigationTiming.php
+++ b/NavigationTiming.php
@@ -54,7 +54,7 @@
}
$wgEventLoggingSchemas += array(
'NavigationTiming' = 10785754,
- 'SaveTiming' = 10785299,
+ 'SaveTiming' = 12236257,
);
$wgHooks[ 'BeforePageDisplay' ][] = function ( $out, $skin ) {
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 53d37f3..dec8229 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -172,8 +172,10 @@
}
navTiming = getNavTiming();
- if ( navTiming ) {
- mw.eventLog.logEvent( 'SaveTiming', { duration:
navTiming.responseStart } );
+ if ( navTiming navTiming.responseStart ) {
+ mw.eventLog.logEvent( 'SaveTiming', {
+ saveTiming: navTiming.responseStart
+ } );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/21
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: wmf/1.26wmf6
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bump SaveTiming SCID to 12236257 - change (mediawiki...NavigationTiming)
jenkins-bot has submitted this change and it was merged.
Change subject: Bump SaveTiming SCID to 12236257
..
Bump SaveTiming SCID to 12236257
* 'duration' renamed to 'saveDuration' and marked as required.
Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
---
M NavigationTiming.php
M modules/ext.navigationTiming.js
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/NavigationTiming.php b/NavigationTiming.php
index 2b4a8af..8111b22 100644
--- a/NavigationTiming.php
+++ b/NavigationTiming.php
@@ -54,7 +54,7 @@
}
$wgEventLoggingSchemas += array(
'NavigationTiming' = 10785754,
- 'SaveTiming' = 10785299,
+ 'SaveTiming' = 12236257,
);
$wgHooks[ 'BeforePageDisplay' ][] = function ( $out, $skin ) {
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 53d37f3..dec8229 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -172,8 +172,10 @@
}
navTiming = getNavTiming();
- if ( navTiming ) {
- mw.eventLog.logEvent( 'SaveTiming', { duration:
navTiming.responseStart } );
+ if ( navTiming navTiming.responseStart ) {
+ mw.eventLog.logEvent( 'SaveTiming', {
+ saveTiming: navTiming.responseStart
+ } );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/212223
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: wmf/1.26wmf5
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bump SaveTiming SCID to 12236257 - change (mediawiki...NavigationTiming)
jenkins-bot has submitted this change and it was merged.
Change subject: Bump SaveTiming SCID to 12236257
..
Bump SaveTiming SCID to 12236257
* 'duration' renamed to 'saveDuration' and marked as required.
Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
---
M NavigationTiming.php
M modules/ext.navigationTiming.js
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/NavigationTiming.php b/NavigationTiming.php
index 2b4a8af..8111b22 100644
--- a/NavigationTiming.php
+++ b/NavigationTiming.php
@@ -54,7 +54,7 @@
}
$wgEventLoggingSchemas += array(
'NavigationTiming' = 10785754,
- 'SaveTiming' = 10785299,
+ 'SaveTiming' = 12236257,
);
$wgHooks[ 'BeforePageDisplay' ][] = function ( $out, $skin ) {
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 53d37f3..dec8229 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -172,8 +172,10 @@
}
navTiming = getNavTiming();
- if ( navTiming ) {
- mw.eventLog.logEvent( 'SaveTiming', { duration:
navTiming.responseStart } );
+ if ( navTiming navTiming.responseStart ) {
+ mw.eventLog.logEvent( 'SaveTiming', {
+ saveTiming: navTiming.responseStart
+ } );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/212221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I152ee54aa32c9f95677856a3a76437fec89e1488
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
