[MediaWiki-commits] [Gerrit] Call Linker methods statically - change (mediawiki...SmoothGallery)

2014-01-14 Thread Nikerabbit (Code Review) 
Nikerabbit has submitted this change and it was merged.

Change subject: Call Linker methods statically
..


Call Linker methods statically

Change-Id: I9731915a5ce5c992885cc0c98569b3827f25d5b6
---
M SmoothGalleryParser.php
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Nikerabbit: Verified; Looks good to me, approved



diff --git a/SmoothGalleryParser.php b/SmoothGalleryParser.php
index e27b30a..6ceb2a3 100644
--- a/SmoothGalleryParser.php
+++ b/SmoothGalleryParser.php
@@ -177,7 +177,6 @@
}
 
function parseImage( $title, $parser, $galleryArray, $description ) {
-   global $wgUser;
global $wgSmoothGalleryThumbHeight, $wgSmoothGalleryThumbWidth;
 
$imageArray = Array();
@@ -242,13 +241,11 @@
}
}
 
-   $skin = $wgUser-getSkin();
-
// Everything is checked, and converted; add to the array and 
return
$imageArray[title] = $title;
 
// We need the following for the image's div
-   $imageArray[heading] = $skin-makeKnownLinkObj( 
$img_obj-getTitle(), $img_obj-getName() );
+   $imageArray[heading] = Linker::makeKnownLinkObj( 
$img_obj-getTitle(), $img_obj-getName() );
$imageArray[description] = $description;
$imageArray[full_url] = $title-getFullURL();
$imageArray[view_url] = $img_obj-getViewURL();

-- 
To view, visit https://gerrit.wikimedia.org/r/106941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9731915a5ce5c992885cc0c98569b3827f25d5b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SmoothGallery
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Call Linker methods statically - change (mediawiki...SmoothGallery)

2014-01-11 Thread Siebrand (Code Review) 
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/106941


Change subject: Call Linker methods statically
..

Call Linker methods statically

Change-Id: I9731915a5ce5c992885cc0c98569b3827f25d5b6
---
M SmoothGalleryParser.php
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SmoothGallery 
refs/changes/41/106941/1

diff --git a/SmoothGalleryParser.php b/SmoothGalleryParser.php
index e27b30a..6ceb2a3 100644
--- a/SmoothGalleryParser.php
+++ b/SmoothGalleryParser.php
@@ -177,7 +177,6 @@
}
 
function parseImage( $title, $parser, $galleryArray, $description ) {
-   global $wgUser;
global $wgSmoothGalleryThumbHeight, $wgSmoothGalleryThumbWidth;
 
$imageArray = Array();
@@ -242,13 +241,11 @@
}
}
 
-   $skin = $wgUser-getSkin();
-
// Everything is checked, and converted; add to the array and 
return
$imageArray[title] = $title;
 
// We need the following for the image's div
-   $imageArray[heading] = $skin-makeKnownLinkObj( 
$img_obj-getTitle(), $img_obj-getName() );
+   $imageArray[heading] = Linker::makeKnownLinkObj( 
$img_obj-getTitle(), $img_obj-getName() );
$imageArray[description] = $description;
$imageArray[full_url] = $title-getFullURL();
$imageArray[view_url] = $img_obj-getViewURL();

-- 
To view, visit https://gerrit.wikimedia.org/r/106941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9731915a5ce5c992885cc0c98569b3827f25d5b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SmoothGallery
Gerrit-Branch: master
Gerrit-Owner: Siebrand siebr...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits