[MediaWiki-commits] [Gerrit] Call to a member function getCommonMetaArray() on a non-obje... - change (mediawiki/core)

2014-01-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Call to a member function getCommonMetaArray() on a non-object 
at File.php on line 586
..


Call to a member function getCommonMetaArray() on a non-object at
File.php on line 586

Bug: 59785
Change-Id: I7163f3fd122922a28519b7cb1d3d4cd4b81165ee
---
M includes/filerepo/file/File.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/filerepo/file/File.php b/includes/filerepo/file/File.php
index dc35016..c9e435e 100644
--- a/includes/filerepo/file/File.php
+++ b/includes/filerepo/file/File.php
@@ -583,6 +583,9 @@
public function getCommonMetaArray() {
$handler = $this->getHandler();
 
+   if ( !$handler ) {
+   return false;
+   }
return $handler->getCommonMetaArray( $this );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/105998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7163f3fd122922a28519b7cb1d3d4cd4b81165ee
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Call to a member function getCommonMetaArray() on a non-obje... - change (mediawiki/core)

2014-01-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Call to a member function getCommonMetaArray() on a non-object 
at File.php on line 586
..


Call to a member function getCommonMetaArray() on a non-object at
File.php on line 586

Bug: 59785
Change-Id: I7163f3fd122922a28519b7cb1d3d4cd4b81165ee
(cherry picked from commit 5293f35aa73c4b8ff148d966605876e665738c9e)
---
M includes/filerepo/file/File.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/filerepo/file/File.php b/includes/filerepo/file/File.php
index dc35016..c9e435e 100644
--- a/includes/filerepo/file/File.php
+++ b/includes/filerepo/file/File.php
@@ -583,6 +583,9 @@
public function getCommonMetaArray() {
$handler = $this->getHandler();
 
+   if ( !$handler ) {
+   return false;
+   }
return $handler->getCommonMetaArray( $this );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/106007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7163f3fd122922a28519b7cb1d3d4cd4b81165ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.23wmf9
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Call to a member function getCommonMetaArray() on a non-obje... - change (mediawiki/core)

2014-01-07 Thread Reedy (Code Review) 
Reedy has submitted this change and it was merged.

Change subject: Call to a member function getCommonMetaArray() on a non-object 
at File.php on line 586
..


Call to a member function getCommonMetaArray() on a non-object at
File.php on line 586

Bug: 59785
Change-Id: I7163f3fd122922a28519b7cb1d3d4cd4b81165ee
(cherry picked from commit 5293f35aa73c4b8ff148d966605876e665738c9e)
---
M includes/filerepo/file/File.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved



diff --git a/includes/filerepo/file/File.php b/includes/filerepo/file/File.php
index dc35016..c9e435e 100644
--- a/includes/filerepo/file/File.php
+++ b/includes/filerepo/file/File.php
@@ -583,6 +583,9 @@
public function getCommonMetaArray() {
$handler = $this->getHandler();
 
+   if ( !$handler ) {
+   return false;
+   }
return $handler->getCommonMetaArray( $this );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/106009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7163f3fd122922a28519b7cb1d3d4cd4b81165ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.23wmf8
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Call to a member function getCommonMetaArray() on a non-obje... - change (mediawiki/core)

2014-01-07 Thread Reedy (Code Review) 
Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/105998


Change subject: Call to a member function getCommonMetaArray() on a non-object 
at File.php on line 586
..

Call to a member function getCommonMetaArray() on a non-object at
File.php on line 586

Bug: 59785
Change-Id: I7163f3fd122922a28519b7cb1d3d4cd4b81165ee
---
M includes/filerepo/file/File.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/98/105998/1

diff --git a/includes/filerepo/file/File.php b/includes/filerepo/file/File.php
index dc35016..c9e435e 100644
--- a/includes/filerepo/file/File.php
+++ b/includes/filerepo/file/File.php
@@ -583,6 +583,9 @@
public function getCommonMetaArray() {
$handler = $this->getHandler();
 
+   if ( !$handler ) {
+   return false;
+   }
return $handler->getCommonMetaArray( $this );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/105998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7163f3fd122922a28519b7cb1d3d4cd4b81165ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits