[MediaWiki-commits] [Gerrit] Card 824 - Add Name and Email to EW/RTBT Payment Methods - change (mediawiki...DonationInterface)

2013-02-27 Thread Mwalker (Code Review) 
Mwalker has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/51187


Change subject: Card 824 - Add Name and Email to EW/RTBT Payment Methods
..

Card 824 - Add Name and Email to EW/RTBT Payment Methods

Effectively removing the anonymity benefits because apparently that
doesn't matter.

Also -- We need a better way to present 'optional' fields.

Change-Id: Iefaa3cd5d61352a781d231e106c8535e0eff4865
---
M globalcollect_gateway/forms/html/ew/ew-webmoney.html
M globalcollect_gateway/forms/html/ew/ew-yandex.html
M globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html
M globalcollect_gateway/forms/html/rtbt/rtbt-sofo-GB.html
M globalcollect_gateway/forms/html/rtbt/rtbt-sofo.html
5 files changed, 27 insertions(+), 30 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/87/51187/1

diff --git a/globalcollect_gateway/forms/html/ew/ew-webmoney.html 
b/globalcollect_gateway/forms/html/ew/ew-webmoney.html
index 300bee6..1fb9db3 100644
--- a/globalcollect_gateway/forms/html/ew/ew-webmoney.html
+++ b/globalcollect_gateway/forms/html/ew/ew-webmoney.html
@@ -38,6 +38,12 @@
 /div
 /td
 /tr
+   tr
+   td colspan=2
+   input 
class=halfwidth optional id=fname name=fname 
title=%donate_interface-donor-fname% value=@fname 
placeholder=%donate_interface-donor-fname%/
+   input 
class=halfwidth leftmar optional id=lname name=lname 
title=%donate_interface-donor-lname% value=@lname 
placeholder=%donate_interface-donor-lname%/
+   /td
+   /tr
 {% block optional_email %}
 tr
 td colspan=2
@@ -111,13 +117,10 @@
 input type=hidden value=ew name=payment_method/
 input type=hidden value=ew_webmoney 
name=payment_submethod/
 !-- required fields omitted above --
-input class=optional type=hidden value= 
name=fname id=fname /
-input class=optional type=hidden value= 
name=lname id=lname /
 input class=optional type=hidden value= 
name=street id=street /
 input class=optional type=hidden value= name=city 
id=city /
 input class=optional type=hidden value= 
name=state id=state /
 input class=optional type=hidden value= name=zip 
id=zip /
-!--input class=optional type=hidden value= 
name=emailAdd id=emailAdd /--
 /form
 /div
 p 
id=informationsharing%donate_interface-informationsharing|url%/p
diff --git a/globalcollect_gateway/forms/html/ew/ew-yandex.html 
b/globalcollect_gateway/forms/html/ew/ew-yandex.html
index 2cf4fb1..16f5d7a 100644
--- a/globalcollect_gateway/forms/html/ew/ew-yandex.html
+++ b/globalcollect_gateway/forms/html/ew/ew-yandex.html
@@ -38,6 +38,12 @@
/div
/td
/tr
+   tr
+   td colspan=2
+   input 
class=halfwidth optional id=fname name=fname 
title=%donate_interface-donor-fname% value=@fname 
placeholder=%donate_interface-donor-fname%/
+   input 
class=halfwidth leftmar optional id=lname name=lname 
title=%donate_interface-donor-lname% value=@lname 
placeholder=%donate_interface-donor-lname%/
+   /td
+   /tr
{% block optional_email %}
 tr
 td
@@ -80,13 +86,10 @@
input type=hidden value=ew 
name=payment_method/
 input type=hidden value=ew_yandex 
name=payment_submethod/
 !-- required fields omitted above --
-input type=hidden class=optional value= name=fname 
id=fname /
-input type=hidden class=optional value= name=lname 
id=lname /
 input type=hidden class=optional value= name=street 
id=street /
 input type=hidden class=optional value= name=city 
id=city /
 input type=hidden class=optional value=

[MediaWiki-commits] [Gerrit] Card 824 - Add Name and Email to EW/RTBT Payment Methods - change (mediawiki...DonationInterface)

2013-02-27 Thread Pgehres (Code Review) 
Pgehres has submitted this change and it was merged.

Change subject: Card 824 - Add Name and Email to EW/RTBT Payment Methods
..


Card 824 - Add Name and Email to EW/RTBT Payment Methods

Effectively removing the anonymity benefits because apparently that
doesn't matter.

Also -- We need a better way to present 'optional' fields.

Change-Id: Iefaa3cd5d61352a781d231e106c8535e0eff4865
---
M globalcollect_gateway/forms/html/ew/ew-webmoney.html
M globalcollect_gateway/forms/html/ew/ew-yandex.html
M globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html
M globalcollect_gateway/forms/html/rtbt/rtbt-sofo-GB.html
M globalcollect_gateway/forms/html/rtbt/rtbt-sofo.html
5 files changed, 27 insertions(+), 30 deletions(-)

Approvals:
  Pgehres: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/globalcollect_gateway/forms/html/ew/ew-webmoney.html 
b/globalcollect_gateway/forms/html/ew/ew-webmoney.html
index 300bee6..1fb9db3 100644
--- a/globalcollect_gateway/forms/html/ew/ew-webmoney.html
+++ b/globalcollect_gateway/forms/html/ew/ew-webmoney.html
@@ -38,6 +38,12 @@
 /div
 /td
 /tr
+   tr
+   td colspan=2
+   input 
class=halfwidth optional id=fname name=fname 
title=%donate_interface-donor-fname% value=@fname 
placeholder=%donate_interface-donor-fname%/
+   input 
class=halfwidth leftmar optional id=lname name=lname 
title=%donate_interface-donor-lname% value=@lname 
placeholder=%donate_interface-donor-lname%/
+   /td
+   /tr
 {% block optional_email %}
 tr
 td colspan=2
@@ -111,13 +117,10 @@
 input type=hidden value=ew name=payment_method/
 input type=hidden value=ew_webmoney 
name=payment_submethod/
 !-- required fields omitted above --
-input class=optional type=hidden value= 
name=fname id=fname /
-input class=optional type=hidden value= 
name=lname id=lname /
 input class=optional type=hidden value= 
name=street id=street /
 input class=optional type=hidden value= name=city 
id=city /
 input class=optional type=hidden value= 
name=state id=state /
 input class=optional type=hidden value= name=zip 
id=zip /
-!--input class=optional type=hidden value= 
name=emailAdd id=emailAdd /--
 /form
 /div
 p 
id=informationsharing%donate_interface-informationsharing|url%/p
diff --git a/globalcollect_gateway/forms/html/ew/ew-yandex.html 
b/globalcollect_gateway/forms/html/ew/ew-yandex.html
index 2cf4fb1..16f5d7a 100644
--- a/globalcollect_gateway/forms/html/ew/ew-yandex.html
+++ b/globalcollect_gateway/forms/html/ew/ew-yandex.html
@@ -38,6 +38,12 @@
/div
/td
/tr
+   tr
+   td colspan=2
+   input 
class=halfwidth optional id=fname name=fname 
title=%donate_interface-donor-fname% value=@fname 
placeholder=%donate_interface-donor-fname%/
+   input 
class=halfwidth leftmar optional id=lname name=lname 
title=%donate_interface-donor-lname% value=@lname 
placeholder=%donate_interface-donor-lname%/
+   /td
+   /tr
{% block optional_email %}
 tr
 td
@@ -80,13 +86,10 @@
input type=hidden value=ew 
name=payment_method/
 input type=hidden value=ew_yandex 
name=payment_submethod/
 !-- required fields omitted above --
-input type=hidden class=optional value= name=fname 
id=fname /
-input type=hidden class=optional value= name=lname 
id=lname /
 input type=hidden class=optional value= name=street 
id=street /
 input type=hidden class=optional value= name=city 
id=city /
 input type=hidden class=optional value= name=state 
id=state /
 input type=hidden