[MediaWiki-commits] [Gerrit] Consistency tweaks, round 2 - change (mediawiki...MediaWikiChat)

2014-01-12 Thread UltrasonicNXT (Code Review) 
UltrasonicNXT has submitted this change and it was merged.

Change subject: Consistency tweaks, round 2
..


Consistency tweaks, round 2

* Add PLURAL
* Fix UTF-8 encodig

PS2: Per Siebrans's CR
PS3: Add mediawiki.jqueryMsg dependency for PLURAL to work

Change-Id: I0d7fefe0a82ca07bc2ccfdd03862881329f1463f
---
M MediaWikiChat.i18n.php
M MediaWikiChat.php
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  UltrasonicNXT: Verified; Looks good to me, approved



diff --git a/MediaWikiChat.i18n.php b/MediaWikiChat.i18n.php
index d2d1102..6c8ea7d 100644
--- a/MediaWikiChat.i18n.php
+++ b/MediaWikiChat.i18n.php
@@ -23,7 +23,7 @@
'chat-just-now' = 'just now',
 
'chat-a-minute-ago' = 'a minute ago',
-   'chat-minutes-ago' = '$1 minutes ago',
+   'chat-minutes-ago' = '{{PLURAL:$1|1 minute|$1 minutes}} ago',
 
'chat-yesterday' = 'yesterday',
 
diff --git a/MediaWikiChat.php b/MediaWikiChat.php
index 00da406..314c14f 100644
--- a/MediaWikiChat.php
+++ b/MediaWikiChat.php
@@ -6,7 +6,7 @@
  * @ingroup Extensions
  * @version 1.0
  * @author Adam Carter
- * @copyright Copyright © 2013, Adam Carter
+ * @copyright Copyright 2013, Adam Carter
  */
 
 if ( !defined( 'MEDIAWIKI' ) ) {
@@ -46,6 +46,7 @@
'chat-you-are-moderator', 'chat-joined', 'chat-left',
'chat-mod-image', 'chat-yesterday'
),
+   'dependencies' = 'mediawiki.jqueryMsg',
'localBasePath' = dirname( __FILE__ ),
'remoteExtPath' = 'MediaWikiChat',
 );

-- 
To view, visit https://gerrit.wikimedia.org/r/106887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d7fefe0a82ca07bc2ccfdd03862881329f1463f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MediaWikiChat
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking raimond.spekk...@gmail.com
Gerrit-Reviewer: Siebrand siebr...@wikimedia.org
Gerrit-Reviewer: UltrasonicNXT adamr_car...@btinternet.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Consistency tweaks, round 2 - change (mediawiki...MediaWikiChat)

2014-01-11 Thread Raimond Spekking (Code Review) 
Raimond Spekking has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/106887


Change subject: Consistency tweaks, round 2
..

Consistency tweaks, round 2

* Add PLURAL
* Fix UTF-8 encodig

Change-Id: I0d7fefe0a82ca07bc2ccfdd03862881329f1463f
---
M MediaWikiChat.i18n.php
M MediaWikiChat.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MediaWikiChat 
refs/changes/87/106887/1

diff --git a/MediaWikiChat.i18n.php b/MediaWikiChat.i18n.php
index d2d1102..6c8ea7d 100644
--- a/MediaWikiChat.i18n.php
+++ b/MediaWikiChat.i18n.php
@@ -23,7 +23,7 @@
'chat-just-now' = 'just now',
 
'chat-a-minute-ago' = 'a minute ago',
-   'chat-minutes-ago' = '$1 minutes ago',
+   'chat-minutes-ago' = '{{PLURAL:$1|1 minute|$1 minutes}} ago',
 
'chat-yesterday' = 'yesterday',
 
diff --git a/MediaWikiChat.php b/MediaWikiChat.php
index 00da406..9c01da8 100644
--- a/MediaWikiChat.php
+++ b/MediaWikiChat.php
@@ -6,7 +6,7 @@
  * @ingroup Extensions
  * @version 1.0
  * @author Adam Carter
- * @copyright Copyright © 2013, Adam Carter
+ * @copyright Copyright ® 2013, Adam Carter
  */
 
 if ( !defined( 'MEDIAWIKI' ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/106887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d7fefe0a82ca07bc2ccfdd03862881329f1463f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MediaWikiChat
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking raimond.spekk...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits