[MediaWiki-commits] [Gerrit] Correctly set tablesUsed in test - change (mediawiki...Newsletter)

2015-08-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Correctly set tablesUsed in test
..


Correctly set tablesUsed in test

Change-Id: If9eaba92fe412469fc76afab3a2e72d9d4d7a270
---
M tests/ApiNewsletterTest.php
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  01tonythomas: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/ApiNewsletterTest.php b/tests/ApiNewsletterTest.php
index 15b848a..e394628 100644
--- a/tests/ApiNewsletterTest.php
+++ b/tests/ApiNewsletterTest.php
@@ -11,6 +11,13 @@
  */
 class ApiNewsletterTest extends ApiTestCase {
 
+   public function __construct( $name = null, array $data = array(), 
$dataName = '' ) {
+   parent::__construct( $name, $data, $dataName );
+
+   $this->tablesUsed[] = 'nl_newsletters';
+   $this->tablesUsed[] = 'nl_subscriptions';
+   }
+
protected function setUp() {
parent::setUp();
$dbw = wfGetDB( DB_MASTER );
@@ -26,7 +33,6 @@
'nl_owner_id' => $user->getId(),
);
$dbw->insert( 'nl_newsletters', $rowData, __METHOD__ );
-   $this->tablesUsed = array( 'nl_newsletters' );
}
 
protected function getNewsletterId() {

-- 
To view, visit https://gerrit.wikimedia.org/r/234128
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9eaba92fe412469fc76afab3a2e72d9d4d7a270
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Addshore 
Gerrit-Reviewer: 01tonythomas <01tonytho...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Correctly set tablesUsed in test - change (mediawiki...Newsletter)

2015-08-26 Thread Addshore (Code Review) 
Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/234128

Change subject: Correctly set tablesUsed in test
..

Correctly set tablesUsed in test

Change-Id: If9eaba92fe412469fc76afab3a2e72d9d4d7a270
---
M tests/ApiNewsletterTest.php
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter 
refs/changes/28/234128/1

diff --git a/tests/ApiNewsletterTest.php b/tests/ApiNewsletterTest.php
index 15b848a..e394628 100644
--- a/tests/ApiNewsletterTest.php
+++ b/tests/ApiNewsletterTest.php
@@ -11,6 +11,13 @@
  */
 class ApiNewsletterTest extends ApiTestCase {
 
+   public function __construct( $name = null, array $data = array(), 
$dataName = '' ) {
+   parent::__construct( $name, $data, $dataName );
+
+   $this->tablesUsed[] = 'nl_newsletters';
+   $this->tablesUsed[] = 'nl_subscriptions';
+   }
+
protected function setUp() {
parent::setUp();
$dbw = wfGetDB( DB_MASTER );
@@ -26,7 +33,6 @@
'nl_owner_id' => $user->getId(),
);
$dbw->insert( 'nl_newsletters', $rowData, __METHOD__ );
-   $this->tablesUsed = array( 'nl_newsletters' );
}
 
protected function getNewsletterId() {

-- 
To view, visit https://gerrit.wikimedia.org/r/234128
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9eaba92fe412469fc76afab3a2e72d9d4d7a270
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Addshore 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits