[MediaWiki-commits] [Gerrit] Decode an escaped data attribute before making an API request - change (mediawiki...MobileFrontend)

2016-02-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Decode an escaped data attribute before making an API request
..


Decode an escaped data attribute before making an API request

This step is especially important when the page title is
in cyrillic.

Bug: T127190
Change-Id: Ieb390e6be70b39027196f53f5b8b1661160c3cd1
(cherry picked from commit 7e23ce8db3d67c9f9c20b6f982167a86f49725aa)
---
M resources/skins.minerva.talk/init.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/skins.minerva.talk/init.js 
b/resources/skins.minerva.talk/init.js
index 5475c38..cd2a39d 100644
--- a/resources/skins.minerva.talk/init.js
+++ b/resources/skins.minerva.talk/init.js
@@ -4,7 +4,7 @@
user = M.require( 'mobile.user/user' ),
Button = M.require( 'mobile.startup/Button' ),
$talk = $( '.talk' ),
-   title = $talk.data( 'title' ) || mw.config.get( 'wgPageName' ),
+   title = decodeURIComponent( $talk.data( 'title' ) ) || 
mw.config.get( 'wgPageName' ),
page = M.getCurrentPage(),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
skin = M.require( 'skins.minerva.scripts/skin' );

-- 
To view, visit https://gerrit.wikimedia.org/r/273296
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb390e6be70b39027196f53f5b8b1661160c3cd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.27.0-wmf.14
Gerrit-Owner: BryanDavis 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Decode an escaped data attribute before making an API request - change (mediawiki...MobileFrontend)

2016-02-25 Thread BryanDavis (Code Review) 
BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/273296

Change subject: Decode an escaped data attribute before making an API request
..

Decode an escaped data attribute before making an API request

This step is especially important when the page title is
in cyrillic.

Bug: T127190
Change-Id: Ieb390e6be70b39027196f53f5b8b1661160c3cd1
(cherry picked from commit 7e23ce8db3d67c9f9c20b6f982167a86f49725aa)
---
M resources/skins.minerva.talk/init.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/96/273296/1

diff --git a/resources/skins.minerva.talk/init.js 
b/resources/skins.minerva.talk/init.js
index 5475c38..cd2a39d 100644
--- a/resources/skins.minerva.talk/init.js
+++ b/resources/skins.minerva.talk/init.js
@@ -4,7 +4,7 @@
user = M.require( 'mobile.user/user' ),
Button = M.require( 'mobile.startup/Button' ),
$talk = $( '.talk' ),
-   title = $talk.data( 'title' ) || mw.config.get( 'wgPageName' ),
+   title = decodeURIComponent( $talk.data( 'title' ) ) || 
mw.config.get( 'wgPageName' ),
page = M.getCurrentPage(),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
skin = M.require( 'skins.minerva.scripts/skin' );

-- 
To view, visit https://gerrit.wikimedia.org/r/273296
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb390e6be70b39027196f53f5b8b1661160c3cd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf/1.27.0-wmf.14
Gerrit-Owner: BryanDavis 
Gerrit-Reviewer: Bmansurov 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Decode an escaped data attribute before making an API request - change (mediawiki...MobileFrontend)

2016-02-18 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Decode an escaped data attribute before making an API request
..


Decode an escaped data attribute before making an API request

This step is especially important when the page title is
in cyrillic.

Bug: T127190
Change-Id: Ieb390e6be70b39027196f53f5b8b1661160c3cd1
---
M resources/skins.minerva.talk/init.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jhobs: Looks good to me, but someone else must approve
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/skins.minerva.talk/init.js 
b/resources/skins.minerva.talk/init.js
index 5475c38..cd2a39d 100644
--- a/resources/skins.minerva.talk/init.js
+++ b/resources/skins.minerva.talk/init.js
@@ -4,7 +4,7 @@
user = M.require( 'mobile.user/user' ),
Button = M.require( 'mobile.startup/Button' ),
$talk = $( '.talk' ),
-   title = $talk.data( 'title' ) || mw.config.get( 'wgPageName' ),
+   title = decodeURIComponent( $talk.data( 'title' ) ) || 
mw.config.get( 'wgPageName' ),
page = M.getCurrentPage(),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
skin = M.require( 'skins.minerva.scripts/skin' );

-- 
To view, visit https://gerrit.wikimedia.org/r/271454
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb390e6be70b39027196f53f5b8b1661160c3cd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Jhobs 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Decode an escaped data attribute before making an API request - change (mediawiki...MobileFrontend)

2016-02-17 Thread Bmansurov (Code Review) 
Bmansurov has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/271454

Change subject: Decode an escaped data attribute before making an API request
..

Decode an escaped data attribute before making an API request

This step is especially important when the page title is
in cyrillic.

Bug: T127190
Change-Id: Ieb390e6be70b39027196f53f5b8b1661160c3cd1
---
M resources/skins.minerva.talk/init.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/54/271454/1

diff --git a/resources/skins.minerva.talk/init.js 
b/resources/skins.minerva.talk/init.js
index 5475c38..cd2a39d 100644
--- a/resources/skins.minerva.talk/init.js
+++ b/resources/skins.minerva.talk/init.js
@@ -4,7 +4,7 @@
user = M.require( 'mobile.user/user' ),
Button = M.require( 'mobile.startup/Button' ),
$talk = $( '.talk' ),
-   title = $talk.data( 'title' ) || mw.config.get( 'wgPageName' ),
+   title = decodeURIComponent( $talk.data( 'title' ) ) || 
mw.config.get( 'wgPageName' ),
page = M.getCurrentPage(),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
skin = M.require( 'skins.minerva.scripts/skin' );

-- 
To view, visit https://gerrit.wikimedia.org/r/271454
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb390e6be70b39027196f53f5b8b1661160c3cd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits