[MediaWiki-commits] [Gerrit] Defined WikiFont characters rather than pasting raw chars. - change (apps...wikipedia)

2014-04-30 Thread Brion VIBBER (Code Review) 
Brion VIBBER has submitted this change and it was merged.

Change subject: Defined WikiFont characters rather than pasting raw chars.
..


Defined WikiFont characters rather than pasting raw chars.

As Brion pointed out, the raw chars don't render in xCode so
they're hard to read.

The define names I used are based on the names from the names
from the WikiFont repo's font.css file.

Change-Id: Ic7515a61ebdb8bcc4111d18eb9f5118e88dc689c
---
M Wikipedia.xcodeproj/project.pbxproj
A wikipedia/Defines/WMF_WikiFont_Chars.h
M wikipedia/View Controllers/MainMenu/MainMenuViewController.m
M wikipedia/View Controllers/PageHistory/PageHistoryViewController.m
M wikipedia/View Controllers/TopNav/NavController.m
5 files changed, 190 insertions(+), 21 deletions(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git a/Wikipedia.xcodeproj/project.pbxproj 
b/Wikipedia.xcodeproj/project.pbxproj
index 1afeab0..cc51073 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -279,6 +279,7 @@
0466F44E183A30CC00EA1FD7 /* logo-search-placehol...@2x.png */ = 
{isa = PBXFileReference; lastKnownFileType = image.png; path = 
logo-search-placehol...@2x.png; sourceTree = group; };
04735E5E18A5B42D00C89C30 /* LoginTokenOp.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
LoginTokenOp.h; sourceTree = group; };
04735E5F18A5B42D00C89C30 /* LoginTokenOp.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= LoginTokenOp.m; sourceTree = group; };
+   047528A3190F0C2900F2CDA8 /* WMF_WikiFont_Chars.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
WMF_WikiFont_Chars.h; sourceTree = group; };
0476967A18BBFC9400071963 /* AccountCreationOp.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
AccountCreationOp.h; sourceTree = group; };
0476967B18BBFC9400071963 /* AccountCreationOp.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= AccountCreationOp.m; sourceTree = group; };
047801BC18AE987900DBB747 /* UIButton+ColorMask.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
UIButton+ColorMask.h; sourceTree = group; };
@@ -641,6 +642,7 @@
children = (
04292FFC185FC026002A13FC /* Defines.h */,
043F18F118DCDD3A00D8489A /* WMF_Colors.h */,
+   047528A3190F0C2900F2CDA8 /* 
WMF_WikiFont_Chars.h */,
);
path = Defines;
sourceTree = group;
diff --git a/wikipedia/Defines/WMF_WikiFont_Chars.h 
b/wikipedia/Defines/WMF_WikiFont_Chars.h
new file mode 100644
index 000..b2eebb7
--- /dev/null
+++ b/wikipedia/Defines/WMF_WikiFont_Chars.h
@@ -0,0 +1,161 @@
+
+/* UI ELEMENTS e000_023 */
+
+#define WIKIFONT_CHAR_MAGNIFYING_GLASS   @\ue000
+
+#define WIKIFONT_CHAR_ARROW_LEFT @\ue001
+
+#define WIKIFONT_CHAR_TICK   @\ue002
+
+#define WIKIFONT_CHAR_X  @\ue003
+
+#define WIKIFONT_CHAR_X_CIRCLE   @\ue004
+
+#define WIKIFONT_CHAR_UNSTAR @\ue005
+
+#define WIKIFONT_CHAR_STAR   @\ue006
+
+#define WIKIFONT_CHAR_SUN@\ue007
+
+#define WIKIFONT_CHAR_STAR_CIRCLE@\ue008
+
+#define WIKIFONT_CHAR_FUNNEL @\ue009
+
+#define WIKIFONT_CHAR_EYE@\ue010
+
+#define WIKIFONT_CHAR_EYE_LID@\ue011
+
+#define WIKIFONT_CHAR_BOOKMARK   @\ue012
+
+#define WIKIFONT_CHAR_PRINTER@\ue013
+
+#define WIKIFONT_CHAR_PUZZLE @\ue014
+
+#define WIKIFONT_CHAR_CLOCK  @\ue015
+
+#define WIKIFONT_CHAR_DICE   @\ue016
+
+#define WIKIFONT_CHAR_MOVE   @\ue017
+
+#define WIKIFONT_CHAR_GEAR   @\ue018
+
+#define WIKIFONT_CHAR_ELLIPSIS   @\ue019
+
+#define WIKIFONT_CHAR_ENVELOPE   @\ue020
+
+#define WIKIFONT_CHAR_PIN@\ue021
+
+#define WIKIFONT_CHAR_CARET  @\ue022
+
+#define WIKIFONT_CHAR_DOWNLOAD   @\ue023
+
+
+
+/* STRIPES e040_043 */
+
+#define WIKIFONT_CHAR_STRIPE_COMPACT @\ue040
+
+#define WIKIFONT_CHAR_STRIPE_TOC @\ue041
+
+#define WIKIFONT_CHAR_STRIPE_EXPANDED@\ue042
+
+
+
+/* WIKIPEDIA LOGO e400_401 */
+
+#define WIKIFONT_CHAR_W  @\ue400
+
+
+
+/* UI MODERATION ELEMENTS e500_508 */
+
+#define WIKIFONT_CHAR_ARTICLE

[MediaWiki-commits] [Gerrit] Defined WikiFont characters rather than pasting raw chars. - change (apps...wikipedia)

2014-04-28 Thread Mhurd (Code Review) 
Mhurd has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/130237

Change subject: Defined WikiFont characters rather than pasting raw chars.
..

Defined WikiFont characters rather than pasting raw chars.

As Brion pointed out, the raw chars don't render in xCode so
they're hard to read.

The define names I used are based on the names from the names
from the WikiFont repo's font.css file.

Change-Id: Ic7515a61ebdb8bcc4111d18eb9f5118e88dc689c
---
M Wikipedia.xcodeproj/project.pbxproj
A wikipedia/Defines/WMF_WikiFont_Chars.h
M wikipedia/View Controllers/MainMenu/MainMenuViewController.m
M wikipedia/View Controllers/PageHistory/PageHistoryViewController.m
M wikipedia/View Controllers/TopNav/NavController.m
5 files changed, 190 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/37/130237/1

diff --git a/Wikipedia.xcodeproj/project.pbxproj 
b/Wikipedia.xcodeproj/project.pbxproj
index 1afeab0..cc51073 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -279,6 +279,7 @@
0466F44E183A30CC00EA1FD7 /* logo-search-placehol...@2x.png */ = 
{isa = PBXFileReference; lastKnownFileType = image.png; path = 
logo-search-placehol...@2x.png; sourceTree = group; };
04735E5E18A5B42D00C89C30 /* LoginTokenOp.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
LoginTokenOp.h; sourceTree = group; };
04735E5F18A5B42D00C89C30 /* LoginTokenOp.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= LoginTokenOp.m; sourceTree = group; };
+   047528A3190F0C2900F2CDA8 /* WMF_WikiFont_Chars.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
WMF_WikiFont_Chars.h; sourceTree = group; };
0476967A18BBFC9400071963 /* AccountCreationOp.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
AccountCreationOp.h; sourceTree = group; };
0476967B18BBFC9400071963 /* AccountCreationOp.m */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path 
= AccountCreationOp.m; sourceTree = group; };
047801BC18AE987900DBB747 /* UIButton+ColorMask.h */ = {isa = 
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = 
UIButton+ColorMask.h; sourceTree = group; };
@@ -641,6 +642,7 @@
children = (
04292FFC185FC026002A13FC /* Defines.h */,
043F18F118DCDD3A00D8489A /* WMF_Colors.h */,
+   047528A3190F0C2900F2CDA8 /* 
WMF_WikiFont_Chars.h */,
);
path = Defines;
sourceTree = group;
diff --git a/wikipedia/Defines/WMF_WikiFont_Chars.h 
b/wikipedia/Defines/WMF_WikiFont_Chars.h
new file mode 100644
index 000..b2eebb7
--- /dev/null
+++ b/wikipedia/Defines/WMF_WikiFont_Chars.h
@@ -0,0 +1,161 @@
+
+/* UI ELEMENTS e000_023 */
+
+#define WIKIFONT_CHAR_MAGNIFYING_GLASS   @\ue000
+
+#define WIKIFONT_CHAR_ARROW_LEFT @\ue001
+
+#define WIKIFONT_CHAR_TICK   @\ue002
+
+#define WIKIFONT_CHAR_X  @\ue003
+
+#define WIKIFONT_CHAR_X_CIRCLE   @\ue004
+
+#define WIKIFONT_CHAR_UNSTAR @\ue005
+
+#define WIKIFONT_CHAR_STAR   @\ue006
+
+#define WIKIFONT_CHAR_SUN@\ue007
+
+#define WIKIFONT_CHAR_STAR_CIRCLE@\ue008
+
+#define WIKIFONT_CHAR_FUNNEL @\ue009
+
+#define WIKIFONT_CHAR_EYE@\ue010
+
+#define WIKIFONT_CHAR_EYE_LID@\ue011
+
+#define WIKIFONT_CHAR_BOOKMARK   @\ue012
+
+#define WIKIFONT_CHAR_PRINTER@\ue013
+
+#define WIKIFONT_CHAR_PUZZLE @\ue014
+
+#define WIKIFONT_CHAR_CLOCK  @\ue015
+
+#define WIKIFONT_CHAR_DICE   @\ue016
+
+#define WIKIFONT_CHAR_MOVE   @\ue017
+
+#define WIKIFONT_CHAR_GEAR   @\ue018
+
+#define WIKIFONT_CHAR_ELLIPSIS   @\ue019
+
+#define WIKIFONT_CHAR_ENVELOPE   @\ue020
+
+#define WIKIFONT_CHAR_PIN@\ue021
+
+#define WIKIFONT_CHAR_CARET  @\ue022
+
+#define WIKIFONT_CHAR_DOWNLOAD   @\ue023
+
+
+
+/* STRIPES e040_043 */
+
+#define WIKIFONT_CHAR_STRIPE_COMPACT @\ue040
+
+#define WIKIFONT_CHAR_STRIPE_TOC @\ue041
+
+#define WIKIFONT_CHAR_STRIPE_EXPANDED@\ue042
+
+
+
+/* WIKIPEDIA LOGO e400_401 */
+
+#define WIKIFONT_CHAR_W  @\ue400
+
+
+
+/* UI MODERATION ELEMENTS