[MediaWiki-commits] [Gerrit] Disable WebView hardware acceleration - change (apps...wikipedia)

2015-11-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Disable WebView hardware acceleration
..


Disable WebView hardware acceleration

Enabling hardware acceleration is causing a variety of Exceptions across
API levels, mostly KitKat, v4.4.4, API 19. Since enabling acceleration
was originally intended to fix T109983 but didn't, this removes the
setting, restoring the default behavior of software rendering. An
alternative solution might be to catch any Throwable emitted when
enabling acceleration but this might put the object in a bad state:

  @Override
  public void setLayerType(int layerType, Paint paint) {
if (ApiUtil.hasLollipop()) {
  try {
super.setLayerType(layerType, paint);
  } catch (Throwable e) {
L.w(e);
  }
}
  }

Change-Id: Ib5f812ed847e7dcf1905a95133db42d4de2a448f
---
M app/src/main/res/layout/fragment_page.xml
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/res/layout/fragment_page.xml 
b/app/src/main/res/layout/fragment_page.xml
index f74fa34..88babab 100644
--- a/app/src/main/res/layout/fragment_page.xml
+++ b/app/src/main/res/layout/fragment_page.xml
@@ -26,8 +26,7 @@
 
+android:layout_height="match_parent" />
 
 https://gerrit.wikimedia.org/r/250366
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5f812ed847e7dcf1905a95133db42d4de2a448f
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Disable WebView hardware acceleration - change (apps...wikipedia)

2015-11-01 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250366

Change subject: Disable WebView hardware acceleration
..

Disable WebView hardware acceleration

Enabling hardware acceleration is causing a variety of Exceptions across
API levels, mostly KitKat, v4.4.4, API 19. Since enabling acceleration
was originally intended to fix T109983 but didn't, this removes the
setting, restoring the default behavior of software rendering. An
alternative solution might be to catch any Throwable emitted when
enabling acceleration but this might put the object in a bad state:

  @Override
  public void setLayerType(int layerType, Paint paint) {
if (ApiUtil.hasLollipop()) {
  try {
super.setLayerType(layerType, paint);
  } catch (Throwable e) {
L.w(e);
  }
}
  }

Change-Id: Ib5f812ed847e7dcf1905a95133db42d4de2a448f
---
M app/src/main/res/layout/fragment_page.xml
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/66/250366/1

diff --git a/app/src/main/res/layout/fragment_page.xml 
b/app/src/main/res/layout/fragment_page.xml
index f74fa34..88babab 100644
--- a/app/src/main/res/layout/fragment_page.xml
+++ b/app/src/main/res/layout/fragment_page.xml
@@ -26,8 +26,7 @@
 
+android:layout_height="match_parent" />
 
 https://gerrit.wikimedia.org/r/250366
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5f812ed847e7dcf1905a95133db42d4de2a448f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits