Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227745
Change subject: Disable scroll animation when running tests
......................................................................
Disable scroll animation when running tests
MW test runner doesn't like animations that haven't finished
when the test complete.
Bug: T107122
Change-Id: I30a022d1ca0e0556f0fde4e6b6a8bd357cc884e3
---
M modules/ve-mw/tests/ve.test.utils.js
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/45/227745/1
diff --git a/modules/ve-mw/tests/ve.test.utils.js
b/modules/ve-mw/tests/ve.test.utils.js
index 9d370ca..f27a3f4 100644
--- a/modules/ve-mw/tests/ve.test.utils.js
+++ b/modules/ve-mw/tests/ve.test.utils.js
@@ -32,7 +32,8 @@
ve.dm.modelRegistry.register( ve.dm.BlockImageNode );
ve.test.utils.mwEnvironment = ( function () {
- var overrides = [
+ var scrollIntoView,
+ overrides = [
ve.dm.MWHeadingNode,
ve.dm.MWPreformattedNode,
ve.dm.MWTableNode
@@ -50,6 +51,9 @@
for ( i = 0; i < overridden.length; i++ ) {
ve.dm.modelRegistry.unregister( overridden[i] );
}
+ // Disable scroll animations
+ scrollIntoView = OO.ui.Element.static.scrollIntoView;
+ OO.ui.Element.static.scrollIntoView = function () {};
}
function teardownOverrides() {
@@ -60,6 +64,10 @@
for ( i = 0; i < overridden.length; i++ ) {
ve.dm.modelRegistry.register( overridden[i] );
}
+ // Restore scroll animations
+ if ( scrollIntoView ) {
+ OO.ui.Element.static.scrollIntoView = scrollIntoView;
+ }
}
// On load, teardown overrides so the first core tests run correctly
--
To view, visit https://gerrit.wikimedia.org/r/227745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30a022d1ca0e0556f0fde4e6b6a8bd357cc884e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
