[MediaWiki-commits] [Gerrit] Don't use $this for docuementing hook parameters - change (mediawiki/core)
IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/132789 Change subject: Don't use $this for docuementing hook parameters .. Don't use $this for docuementing hook parameters It is a reserved keyword, so this only confuses people. Change-Id: I6553bd93ac6f72be42493a0c3ca59c63d4a97e18 --- M docs/hooks.txt 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/89/132789/1 diff --git a/docs/hooks.txt b/docs/hooks.txt index 626ca5e..966afd8 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -281,7 +281,7 @@ 'SendWatchlistEmailNotification': Return true to send watchlist email notification $targetUser: the user whom to send watchlist email notification $title: the page title -$this: EmailNotification object +$enotif: EmailNotification object 'AbortChangePassword': Return false to cancel password change. $user: the User object to which the password change is occuring @@ -2616,7 +2616,7 @@ $whitelisted: Boolean value of whether this title is whitelisted 'TitleSquidURLs': Called to determine which URLs to purge from HTTP caches. -$this: Title object to purge +$title: Title object to purge $urls: An array of URLs to purge from the caches, to be manipulated. 'UndeleteForm::showHistory': Called in UndeleteForm::showHistory, after a -- To view, visit https://gerrit.wikimedia.org/r/132789 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6553bd93ac6f72be42493a0c3ca59c63d4a97e18 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex coderev...@emsenhuber.ch ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Don't use $this for docuementing hook parameters - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Don't use $this for docuementing hook parameters .. Don't use $this for docuementing hook parameters It is a reserved keyword, so this only confuses people. Change-Id: I6553bd93ac6f72be42493a0c3ca59c63d4a97e18 --- M docs/hooks.txt 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/docs/hooks.txt b/docs/hooks.txt index 626ca5e..966afd8 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -281,7 +281,7 @@ 'SendWatchlistEmailNotification': Return true to send watchlist email notification $targetUser: the user whom to send watchlist email notification $title: the page title -$this: EmailNotification object +$enotif: EmailNotification object 'AbortChangePassword': Return false to cancel password change. $user: the User object to which the password change is occuring @@ -2616,7 +2616,7 @@ $whitelisted: Boolean value of whether this title is whitelisted 'TitleSquidURLs': Called to determine which URLs to purge from HTTP caches. -$this: Title object to purge +$title: Title object to purge $urls: An array of URLs to purge from the caches, to be manipulated. 'UndeleteForm::showHistory': Called in UndeleteForm::showHistory, after a -- To view, visit https://gerrit.wikimedia.org/r/132789 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6553bd93ac6f72be42493a0c3ca59c63d4a97e18 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex coderev...@emsenhuber.ch Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com Gerrit-Reviewer: Waldir wal...@email.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
