jenkins-bot has submitted this change and it was merged.
Change subject: Enable ACE webworkers
..
Enable ACE webworkers
Now that the RL path is set correctly we can enable the webworkers
This adds syntax checker and linting
Change-Id: Ie9177d4acae45f2aadb1dfd3e66049195056bca0
---
M modules/jquery.codeEditor.js
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index 15f23cf..31d9408 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -184,9 +184,6 @@
// updated right away to actually use
the new style.
$( mw ).bind( 'LivePreviewPrepare',
context.evt.codeEditorSubmit );
- // Disable code-linting in the
background using JavaScript WebWorkers.
- // Currently broken due to require() /
ResourceLoader mismatch.
- session.setUseWorker( false );
session.setMode( new (require(
ace/mode/ + lang ).Mode) );
// Force the box to resize horizontally
to match in future :D
--
To view, visit https://gerrit.wikimedia.org/r/106673
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9177d4acae45f2aadb1dfd3e66049195056bca0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ hartman.w...@gmail.com
Gerrit-Reviewer: Anomie bjor...@wikimedia.org
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Mattflaschen mflasc...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Umherirrender umherirrender_de...@web.de
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
