[MediaWiki-commits] [Gerrit] Fix fatal from exception, and improve its message - change (mediawiki...Flow)

2014-01-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix fatal from exception, and improve its message
..


Fix fatal from exception, and improve its message

Bug: 59940
Change-Id: Id803f4e950f4ba7f7e78e19804847eb9f5829fed
---
M includes/Model/Workflow.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Werdna: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Model/Workflow.php b/includes/Model/Workflow.php
index 99e9b93..11f038e 100644
--- a/includes/Model/Workflow.php
+++ b/includes/Model/Workflow.php
@@ -5,6 +5,7 @@
 use MWTimestamp;
 use Title;
 use User;
+use Flow\Exception\FlowException;
 use Flow\Exception\DataModelException;
 use Flow\Exception\InvalidInputException;
 
@@ -93,7 +94,7 @@
 
public function getArticleTitle() {
if ( $this-wiki !== wfWikiId() ) {
-   throw new FlowException( 'Interwiki not implemented', 
'default' );
+   throw new FlowException( 'Interwiki to ' . $this-wiki 
. ' not implemented ', 'default' );
}
return Title::makeTitleSafe( $this-namespace, $this-titleText 
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/106869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id803f4e950f4ba7f7e78e19804847eb9f5829fed
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage sp...@wikimedia.org
Gerrit-Reviewer: Bsitu bs...@wikimedia.org
Gerrit-Reviewer: Werdna agarr...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix fatal from exception, and improve its message - change (mediawiki...Flow)

2014-01-11 Thread Spage (Code Review) 
Spage has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/106869


Change subject: Fix fatal from exception, and improve its message
..

Fix fatal from exception, and improve its message

Bug: 599400
Change-Id: Id803f4e950f4ba7f7e78e19804847eb9f5829fed
---
M includes/Model/Workflow.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/69/106869/1

diff --git a/includes/Model/Workflow.php b/includes/Model/Workflow.php
index 99e9b93..11f038e 100644
--- a/includes/Model/Workflow.php
+++ b/includes/Model/Workflow.php
@@ -5,6 +5,7 @@
 use MWTimestamp;
 use Title;
 use User;
+use Flow\Exception\FlowException;
 use Flow\Exception\DataModelException;
 use Flow\Exception\InvalidInputException;
 
@@ -93,7 +94,7 @@
 
public function getArticleTitle() {
if ( $this-wiki !== wfWikiId() ) {
-   throw new FlowException( 'Interwiki not implemented', 
'default' );
+   throw new FlowException( 'Interwiki to ' . $this-wiki 
. ' not implemented ', 'default' );
}
return Title::makeTitleSafe( $this-namespace, $this-titleText 
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/106869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id803f4e950f4ba7f7e78e19804847eb9f5829fed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage sp...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits