[MediaWiki-commits] [Gerrit] Fix for CLDR plural rule parser for old browsers without Str... - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Fix for CLDR plural rule parser for old browsers without 
String.trim
..


Fix for CLDR plural rule parser for old browsers without String.trim

This fixes MobileFrontend's "last modified" message on Kindle 3.4

Submitted upstream as https://github.com/santhoshtr/CLDRPluralRuleParser/pull/10

Bug: 62072
Change-Id: I350264847417f521c111e3cb81da46805608425a
---
M resources/mediawiki.libs/CLDRPluralRuleParser.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Santhosh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mediawiki.libs/CLDRPluralRuleParser.js 
b/resources/mediawiki.libs/CLDRPluralRuleParser.js
index 3def37c..83c2524 100644
--- a/resources/mediawiki.libs/CLDRPluralRuleParser.js
+++ b/resources/mediawiki.libs/CLDRPluralRuleParser.js
@@ -45,7 +45,7 @@
*/
 
// we don't evaluate the samples section of the rule. Ignore it.
-   rule = rule.split('@')[0].trim();
+   rule = rule.split('@')[0].replace(/^\s*/, '').replace(/\s*$/, '');
 
if (!rule.length) {
// empty rule or 'other' rule.

-- 
To view, visit https://gerrit.wikimedia.org/r/116159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I350264847417f521c111e3cb81da46805608425a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 
Gerrit-Reviewer: Cscott 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix for CLDR plural rule parser for old browsers without Str... - change (mediawiki/core)

[Brion VIBBER (Code Review)]

Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/116159

Change subject: Fix for CLDR plural rule parser for old browsers without 
String.trim
..

Fix for CLDR plural rule parser for old browsers without String.trim

This fixes MobileFrontend's "last modified" message on Kindle 3.4

Bug: 62072
Change-Id: I350264847417f521c111e3cb81da46805608425a
---
M resources/mediawiki.libs/CLDRPluralRuleParser.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/59/116159/1

diff --git a/resources/mediawiki.libs/CLDRPluralRuleParser.js 
b/resources/mediawiki.libs/CLDRPluralRuleParser.js
index 3def37c..83c2524 100644
--- a/resources/mediawiki.libs/CLDRPluralRuleParser.js
+++ b/resources/mediawiki.libs/CLDRPluralRuleParser.js
@@ -45,7 +45,7 @@
*/
 
// we don't evaluate the samples section of the rule. Ignore it.
-   rule = rule.split('@')[0].trim();
+   rule = rule.split('@')[0].replace(/^\s*/, '').replace(/\s*$/, '');
 
if (!rule.length) {
// empty rule or 'other' rule.

-- 
To view, visit https://gerrit.wikimedia.org/r/116159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I350264847417f521c111e3cb81da46805608425a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits