[MediaWiki-commits] [Gerrit] Fix gallery top spacing for iOS 7. - change (apps...commons)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix gallery top spacing for iOS 7. .. Fix gallery top spacing for iOS 7. Change-Id: Ib2cd282c5e2953c18fe524337fbe2d85d4d13027 --- M Commons-iOS/GalleryMultiSelectCollectionVC.m 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: Brion VIBBER: Verified; Looks good to me, approved diff --git a/Commons-iOS/GalleryMultiSelectCollectionVC.m b/Commons-iOS/GalleryMultiSelectCollectionVC.m index 01fef2b..b09b2f0 100644 --- a/Commons-iOS/GalleryMultiSelectCollectionVC.m +++ b/Commons-iOS/GalleryMultiSelectCollectionVC.m @@ -10,6 +10,7 @@ #import #import "MWI18N/MWI18N.h" #import "CommonsApp.h" +//#import "UIView+Debugging.h" #pragma mark - Defines @@ -56,6 +57,8 @@ cellScale_ = 1.0f / scale; imageMargin_ = (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) ? GALLERY_IPAD_IMAGE_BORDER_WIDTH : GALLERY_NON_IPAD_IMAGE_BORDER_WIDTH; + +self.wantsFullScreenLayout = YES; } - (id)initWithCoder:(NSCoder *)coder @@ -131,6 +134,8 @@ [self.view addGestureRecognizer:swipeRecognizer_]; [self addNavBar]; + +//[self.view randomlyColorSubviews]; } -(void)setSpacing @@ -140,12 +145,12 @@ UICollectionViewFlowLayout *collectionViewLayout = (UICollectionViewFlowLayout*)self.collectionView.collectionViewLayout; if (UI_USER_INTERFACE_IDIOM() != UIUserInterfaceIdiomPad) { -collectionViewLayout.sectionInset = UIEdgeInsetsMake(60.0f, 15.0f, 60.0f, 15.0f); +collectionViewLayout.sectionInset = UIEdgeInsetsMake(80.0f, 15.0f, 60.0f, 15.0f); collectionViewLayout.minimumInteritemSpacing = 10.0f; // Adds more space for the album labels collectionViewLayout.minimumLineSpacing = (self.galleryMode == GALLERY_SHOW_ALL_ALBUMS) ? 70.0f : 10.0f; }else{ -collectionViewLayout.sectionInset = UIEdgeInsetsMake(80.0f, 40.0f, 80.0f, 40.0f); +collectionViewLayout.sectionInset = UIEdgeInsetsMake(100.0f, 40.0f, 80.0f, 40.0f); collectionViewLayout.minimumInteritemSpacing = 40.0f; // Adds more space for the album labels collectionViewLayout.minimumLineSpacing = (self.galleryMode == GALLERY_SHOW_ALL_ALBUMS) ? 90.0f : 55.0f; @@ -154,7 +159,7 @@ -(void)addNavBar { -navBar_ = [[UINavigationBar alloc] initWithFrame: CGRectMake(0.0f, 0.0f, self.view.frame.size.width, 44.0f)]; +navBar_ = [[UINavigationBar alloc] initWithFrame: CGRectMake(0.0f, [[CommonsApp singleton] getStatusBarHeight], self.view.frame.size.width, 44.0f)]; navBar_.autoresizingMask = UIViewAutoresizingFlexibleWidth; navBar_.barStyle = UIBarStyleBlackTranslucent; [super.view addSubview:navBar_]; -- To view, visit https://gerrit.wikimedia.org/r/88171 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2cd282c5e2953c18fe524337fbe2d85d4d13027 Gerrit-PatchSet: 1 Gerrit-Project: apps/ios/commons Gerrit-Branch: master Gerrit-Owner: Brion VIBBER Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Mhurd ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix gallery top spacing for iOS 7. - change (apps...commons)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/88171 Change subject: Fix gallery top spacing for iOS 7. .. Fix gallery top spacing for iOS 7. Change-Id: Ib2cd282c5e2953c18fe524337fbe2d85d4d13027 --- M Commons-iOS/GalleryMultiSelectCollectionVC.m 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/ios/commons refs/changes/71/88171/1 diff --git a/Commons-iOS/GalleryMultiSelectCollectionVC.m b/Commons-iOS/GalleryMultiSelectCollectionVC.m index 01fef2b..b09b2f0 100644 --- a/Commons-iOS/GalleryMultiSelectCollectionVC.m +++ b/Commons-iOS/GalleryMultiSelectCollectionVC.m @@ -10,6 +10,7 @@ #import #import "MWI18N/MWI18N.h" #import "CommonsApp.h" +//#import "UIView+Debugging.h" #pragma mark - Defines @@ -56,6 +57,8 @@ cellScale_ = 1.0f / scale; imageMargin_ = (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) ? GALLERY_IPAD_IMAGE_BORDER_WIDTH : GALLERY_NON_IPAD_IMAGE_BORDER_WIDTH; + +self.wantsFullScreenLayout = YES; } - (id)initWithCoder:(NSCoder *)coder @@ -131,6 +134,8 @@ [self.view addGestureRecognizer:swipeRecognizer_]; [self addNavBar]; + +//[self.view randomlyColorSubviews]; } -(void)setSpacing @@ -140,12 +145,12 @@ UICollectionViewFlowLayout *collectionViewLayout = (UICollectionViewFlowLayout*)self.collectionView.collectionViewLayout; if (UI_USER_INTERFACE_IDIOM() != UIUserInterfaceIdiomPad) { -collectionViewLayout.sectionInset = UIEdgeInsetsMake(60.0f, 15.0f, 60.0f, 15.0f); +collectionViewLayout.sectionInset = UIEdgeInsetsMake(80.0f, 15.0f, 60.0f, 15.0f); collectionViewLayout.minimumInteritemSpacing = 10.0f; // Adds more space for the album labels collectionViewLayout.minimumLineSpacing = (self.galleryMode == GALLERY_SHOW_ALL_ALBUMS) ? 70.0f : 10.0f; }else{ -collectionViewLayout.sectionInset = UIEdgeInsetsMake(80.0f, 40.0f, 80.0f, 40.0f); +collectionViewLayout.sectionInset = UIEdgeInsetsMake(100.0f, 40.0f, 80.0f, 40.0f); collectionViewLayout.minimumInteritemSpacing = 40.0f; // Adds more space for the album labels collectionViewLayout.minimumLineSpacing = (self.galleryMode == GALLERY_SHOW_ALL_ALBUMS) ? 90.0f : 55.0f; @@ -154,7 +159,7 @@ -(void)addNavBar { -navBar_ = [[UINavigationBar alloc] initWithFrame: CGRectMake(0.0f, 0.0f, self.view.frame.size.width, 44.0f)]; +navBar_ = [[UINavigationBar alloc] initWithFrame: CGRectMake(0.0f, [[CommonsApp singleton] getStatusBarHeight], self.view.frame.size.width, 44.0f)]; navBar_.autoresizingMask = UIViewAutoresizingFlexibleWidth; navBar_.barStyle = UIBarStyleBlackTranslucent; [super.view addSubview:navBar_]; -- To view, visit https://gerrit.wikimedia.org/r/88171 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2cd282c5e2953c18fe524337fbe2d85d4d13027 Gerrit-PatchSet: 1 Gerrit-Project: apps/ios/commons Gerrit-Branch: master Gerrit-Owner: Brion VIBBER Gerrit-Reviewer: Mhurd ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits