[MediaWiki-commits] [Gerrit] Fix report criteria not showing in output mode - change (wikimedia...civicrm-core)

2016-04-27 Thread Eileen (Code Review) 
Eileen has submitted this change and it was merged.

Change subject: Fix report criteria not showing in output mode
..


Fix report criteria not showing in output mode

Bug: TT117168

This is part of the Giant Rabbit report-port and I am adjusting in the upstream 
patch too - still in QA
although the part to do with viewing reports without rendering has been merged

Change-Id: Id800f218d88606f8beeeb342acace6fc3f8e22da
---
M templates/CRM/Report/Form/Statistics.tpl
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Eileen: Verified; Looks good to me, approved



diff --git a/templates/CRM/Report/Form/Statistics.tpl 
b/templates/CRM/Report/Form/Statistics.tpl
index 169a563..44f9323 100644
--- a/templates/CRM/Report/Form/Statistics.tpl
+++ b/templates/CRM/Report/Form/Statistics.tpl
@@ -28,7 +28,7 @@
 {$reportTitle}
 {$reportDate}
   {/if}
-  {if $statistics and $outputMode}
+  {if $statistics}
 
   {foreach from=$statistics.groups item=row}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/285785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id800f218d88606f8beeeb342acace6fc3f8e22da
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/civicrm-core
Gerrit-Branch: civi-4.6.9
Gerrit-Owner: Eileen 
Gerrit-Reviewer: Eileen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix report criteria not showing in output mode - change (wikimedia...civicrm-core)

2016-04-27 Thread Eileen (Code Review) 
Eileen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/285785

Change subject: Fix report criteria not showing in output mode
..

Fix report criteria not showing in output mode

Bug: TT117168

This is part of the Giant Rabbit report-port and I am adjusting in the upstream 
patch too - still in QA
although the part to do with viewing reports without rendering has been merged

Change-Id: Id800f218d88606f8beeeb342acace6fc3f8e22da
---
M templates/CRM/Report/Form/Statistics.tpl
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/civicrm-core 
refs/changes/85/285785/1

diff --git a/templates/CRM/Report/Form/Statistics.tpl 
b/templates/CRM/Report/Form/Statistics.tpl
index 169a563..44f9323 100644
--- a/templates/CRM/Report/Form/Statistics.tpl
+++ b/templates/CRM/Report/Form/Statistics.tpl
@@ -28,7 +28,7 @@
 {$reportTitle}
 {$reportDate}
   {/if}
-  {if $statistics and $outputMode}
+  {if $statistics}
 
   {foreach from=$statistics.groups item=row}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/285785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id800f218d88606f8beeeb342acace6fc3f8e22da
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/civicrm-core
Gerrit-Branch: civi-4.6.9
Gerrit-Owner: Eileen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix report criteria not showing in output mode - change (wikimedia...civicrm-core)

2015-11-13 Thread Eileen (Code Review) 
Eileen has submitted this change and it was merged.

Change subject: Fix report criteria not showing in output mode
..


Fix report criteria not showing in output mode

Bug: TT117168

This is part of the Giant Rabbit report-port and I am adjusting in the upstream 
patch too - still in QA
although the part to do with viewing reports without rendering has been merged

Change-Id: Id800f218d88606f8beeeb342acace6fc3f8e22da
---
M templates/CRM/Report/Form/Statistics.tpl
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Eileen: Verified; Looks good to me, approved



diff --git a/templates/CRM/Report/Form/Statistics.tpl 
b/templates/CRM/Report/Form/Statistics.tpl
index 169a563..44f9323 100644
--- a/templates/CRM/Report/Form/Statistics.tpl
+++ b/templates/CRM/Report/Form/Statistics.tpl
@@ -28,7 +28,7 @@
 {$reportTitle}
 {$reportDate}
   {/if}
-  {if $statistics and $outputMode}
+  {if $statistics}
 
   {foreach from=$statistics.groups item=row}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/252465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id800f218d88606f8beeeb342acace6fc3f8e22da
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/civicrm-core
Gerrit-Branch: master
Gerrit-Owner: Eileen 
Gerrit-Reviewer: Eileen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix report criteria not showing in output mode - change (wikimedia...civicrm-core)

2015-11-11 Thread Eileen (Code Review) 
Eileen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/252465

Change subject: Fix report criteria not showing in output mode
..

Fix report criteria not showing in output mode

Bug: TT117168

This is part of the Giant Rabbit report-port and I am adjusting in the upstream 
patch too - still in QA
although the part to do with viewing reports without rendering has been merged

Change-Id: Id800f218d88606f8beeeb342acace6fc3f8e22da
---
M templates/CRM/Report/Form/Statistics.tpl
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/civicrm-core 
refs/changes/65/252465/1

diff --git a/templates/CRM/Report/Form/Statistics.tpl 
b/templates/CRM/Report/Form/Statistics.tpl
index 169a563..44f9323 100644
--- a/templates/CRM/Report/Form/Statistics.tpl
+++ b/templates/CRM/Report/Form/Statistics.tpl
@@ -28,7 +28,7 @@
 {$reportTitle}
 {$reportDate}
   {/if}
-  {if $statistics and $outputMode}
+  {if $statistics}
 
   {foreach from=$statistics.groups item=row}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/252465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id800f218d88606f8beeeb342acace6fc3f8e22da
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/civicrm-core
Gerrit-Branch: master
Gerrit-Owner: Eileen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits