[MediaWiki-commits] [Gerrit] Fix some PHPDoc - change (mediawiki...Flow)

[Matthias Mullie (Code Review)]

Matthias Mullie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/234285

Change subject: Fix some PHPDoc
..

Fix some PHPDoc

Code still worked fine, but editors couldn't figure out
what classes there were, since they're in another namespace
than the file is in (and they're not use'd).

Change-Id: Iececa94a8fbe5165b74aa2756297c3f62f2cba53
---
M includes/Parsoid/Fixer/BaseHrefFixer.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/85/234285/1

diff --git a/includes/Parsoid/Fixer/BaseHrefFixer.php 
b/includes/Parsoid/Fixer/BaseHrefFixer.php
index 86b8e27..28cb3ff 100644
--- a/includes/Parsoid/Fixer/BaseHrefFixer.php
+++ b/includes/Parsoid/Fixer/BaseHrefFixer.php
@@ -20,7 +20,7 @@
protected $baseHref;
 
/**
-* @param $articlePath Article path setting for wiki
+* @param $articlePath \Article path setting for wiki
 */
public function __construct( $articlePath ) {
$replacedArticlePath = str_replace( '$1', '', $articlePath );
@@ -40,8 +40,8 @@
/**
 * Prefixes the href with base href.
 *
-* @param DOMNode $node Link
-* @param Title $title
+* @param \DOMNode $node Link
+* @param \Title $title
 */
public function apply( \DOMNode $node, \Title $title ) {
if ( !$node instanceof \DOMElement ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/234285
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iececa94a8fbe5165b74aa2756297c3f62f2cba53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix some PHPDoc - change (mediawiki...Flow)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Fix some PHPDoc
..


Fix some PHPDoc

Code still worked fine, but editors couldn't figure out
what classes there were, since they're in another namespace
than the file is in (and they're not use'd).

Change-Id: Iececa94a8fbe5165b74aa2756297c3f62f2cba53
---
M includes/Parsoid/Fixer/BaseHrefFixer.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Sbisson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Parsoid/Fixer/BaseHrefFixer.php 
b/includes/Parsoid/Fixer/BaseHrefFixer.php
index 86b8e27..28cb3ff 100644
--- a/includes/Parsoid/Fixer/BaseHrefFixer.php
+++ b/includes/Parsoid/Fixer/BaseHrefFixer.php
@@ -20,7 +20,7 @@
protected $baseHref;
 
/**
-* @param $articlePath Article path setting for wiki
+* @param $articlePath \Article path setting for wiki
 */
public function __construct( $articlePath ) {
$replacedArticlePath = str_replace( '$1', '', $articlePath );
@@ -40,8 +40,8 @@
/**
 * Prefixes the href with base href.
 *
-* @param DOMNode $node Link
-* @param Title $title
+* @param \DOMNode $node Link
+* @param \Title $title
 */
public function apply( \DOMNode $node, \Title $title ) {
if ( !$node instanceof \DOMElement ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/234285
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iececa94a8fbe5165b74aa2756297c3f62f2cba53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org
Gerrit-Reviewer: Sbisson sbis...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits