[MediaWiki-commits] [Gerrit] Fix structure suite - change (mediawiki...MobileFrontend)

2014-12-18 Thread Phuedx (Code Review) 
Phuedx has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/180748

Change subject: Fix structure suite
..

Fix structure suite

The mobile.site and mobile.usermodule RL modules don't have the
desktop target while the modules that use them do, which causes the
structure test suite to fail.

Change-Id: Ifce458e31ad794750f7ba2719e1ef6a61836b44a
---
M includes/modules/MobileSiteModule.php
M includes/modules/MobileUserModule.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/48/180748/1

diff --git a/includes/modules/MobileSiteModule.php 
b/includes/modules/MobileSiteModule.php
index 4848179..e3cc71c 100644
--- a/includes/modules/MobileSiteModule.php
+++ b/includes/modules/MobileSiteModule.php
@@ -8,7 +8,7 @@
  */
 class MobileSiteModule extends ResourceLoaderSiteModule {
/** @var array Saves the target for the module (e.g. desktop and 
mobile). */
-   protected $targets = array( 'mobile' );
+   protected $targets = array( 'mobile', 'desktop' );
 
/**
 * Gets list of pages used by this module.
diff --git a/includes/modules/MobileUserModule.php 
b/includes/modules/MobileUserModule.php
index f3cb158..3e8e483 100644
--- a/includes/modules/MobileUserModule.php
+++ b/includes/modules/MobileUserModule.php
@@ -8,7 +8,7 @@
  */
 class MobileUserModule extends ResourceLoaderUserModule {
/** @var array Sets the target for the module (e.g. desktop and 
mobile). */
-   protected $targets = array( 'mobile' );
+   protected $targets = array( 'mobile', 'desktop' );
 
/**
 * Gets list of pages used by this module.

-- 
To view, visit https://gerrit.wikimedia.org/r/180748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifce458e31ad794750f7ba2719e1ef6a61836b44a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx g...@samsmith.io

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix structure suite - change (mediawiki...MobileFrontend)

2014-12-18 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix structure suite
..


Fix structure suite

The mobile.site and mobile.usermodule RL modules don't have the
desktop target while the modules that use them do, which causes the
structure test suite to fail.

Change-Id: Ifce458e31ad794750f7ba2719e1ef6a61836b44a
---
M includes/modules/MobileSiteModule.php
M includes/modules/MobileUserModule.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jhernandez: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/modules/MobileSiteModule.php 
b/includes/modules/MobileSiteModule.php
index 4848179..e3cc71c 100644
--- a/includes/modules/MobileSiteModule.php
+++ b/includes/modules/MobileSiteModule.php
@@ -8,7 +8,7 @@
  */
 class MobileSiteModule extends ResourceLoaderSiteModule {
/** @var array Saves the target for the module (e.g. desktop and 
mobile). */
-   protected $targets = array( 'mobile' );
+   protected $targets = array( 'mobile', 'desktop' );
 
/**
 * Gets list of pages used by this module.
diff --git a/includes/modules/MobileUserModule.php 
b/includes/modules/MobileUserModule.php
index f3cb158..3e8e483 100644
--- a/includes/modules/MobileUserModule.php
+++ b/includes/modules/MobileUserModule.php
@@ -8,7 +8,7 @@
  */
 class MobileUserModule extends ResourceLoaderUserModule {
/** @var array Sets the target for the module (e.g. desktop and 
mobile). */
-   protected $targets = array( 'mobile' );
+   protected $targets = array( 'mobile', 'desktop' );
 
/**
 * Gets list of pages used by this module.

-- 
To view, visit https://gerrit.wikimedia.org/r/180748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifce458e31ad794750f7ba2719e1ef6a61836b44a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx g...@samsmith.io
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Jhernandez jhernan...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits