[MediaWiki-commits] [Gerrit] Fixed RuboCop offense Lint/UselessAssignment - change (mediawiki...api)

2014-10-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fixed RuboCop offense Lint/UselessAssignment
..


Fixed RuboCop offense Lint/UselessAssignment

Bug: 63307
Change-Id: I89eb92a64a15490e3a5042ec86733bc5884122b9
---
M .rubocop_todo.yml
M spec/client_spec.rb
2 files changed, 1 insertion(+), 9 deletions(-)

Approvals:
  Dduvall: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index e24e71c..b3f07c5 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -5,10 +5,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-Lint/UselessAssignment:
-  Enabled: false
-
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
diff --git a/spec/client_spec.rb b/spec/client_spec.rb
index cc828be..7a59b5c 100644
--- a/spec/client_spec.rb
+++ b/spec/client_spec.rb
@@ -158,8 +158,6 @@
 
 context 'when API returns NeedToken' do
   before do
-headers = { 'Set-Cookie' = 'prefixSession=789; path=/; 
domain=localhost; HttpOnly' }
-
 stub_request(:post, api_url).
   with(body: { format: 'json', action: 'login', lgname: 'Test', 
lgpassword: 'qwe123' }).
   to_return(
@@ -181,7 +179,7 @@
   end
 
   it 'sends second request with token and cookies' do
-response = subject.log_in('Test', 'qwe123')
+subject.log_in('Test', 'qwe123')
 
 expect(@success_req).to have_been_requested
   end
@@ -288,8 +286,6 @@
 
 context 'when API returns NeedToken' do
   before do
-headers = { 'Set-Cookie' = 'prefixSession=789; path=/; 
domain=localhost; HttpOnly' }
-
 stub_request(:post, api_url).
   with(body: { format: 'json', action: 'createaccount', name: 'Test', 
password: 'qwe123' }).
   to_return(

-- 
To view, visit https://gerrit.wikimedia.org/r/168292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89eb92a64a15490e3a5042ec86733bc5884122b9
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/ruby/api
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org
Gerrit-Reviewer: Dduvall dduv...@wikimedia.org
Gerrit-Reviewer: Zfilipin zfili...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed RuboCop offense Lint/UselessAssignment - change (mediawiki...api)

2014-10-23 Thread Zfilipin (Code Review) 
Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/168292

Change subject: Fixed RuboCop offense Lint/UselessAssignment
..

Fixed RuboCop offense Lint/UselessAssignment

Fixed 2 out of 3 problems, not sure how to fix the remaining one.

Bug: 63307
Change-Id: I89eb92a64a15490e3a5042ec86733bc5884122b9
---
M .rubocop_todo.yml
M spec/client_spec.rb
2 files changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/ruby/api 
refs/changes/92/168292/1

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index ca15728..1cc5ef4 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -5,7 +5,7 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
+# Offense count: 1
 Lint/UselessAssignment:
   Enabled: false
 
diff --git a/spec/client_spec.rb b/spec/client_spec.rb
index 7a5797f..44b06d4 100644
--- a/spec/client_spec.rb
+++ b/spec/client_spec.rb
@@ -158,8 +158,6 @@
 
 context 'when API returns NeedToken' do
   before do
-headers = { 'Set-Cookie' = 'prefixSession=789; path=/; 
domain=localhost; HttpOnly' }
-
 stub_request(:post, api_url)
   .with(body: { format: 'json', action: 'login', lgname: 'Test', 
lgpassword: 'qwe123' })
   .to_return(
@@ -288,8 +286,6 @@
 
 context 'when API returns NeedToken' do
   before do
-headers = { 'Set-Cookie' = 'prefixSession=789; path=/; 
domain=localhost; HttpOnly' }
-
 stub_request(:post, api_url)
   .with(body: { format: 'json', action: 'createaccount', name: 'Test', 
password: 'qwe123' })
   .to_return(

-- 
To view, visit https://gerrit.wikimedia.org/r/168292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I89eb92a64a15490e3a5042ec86733bc5884122b9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/ruby/api
Gerrit-Branch: master
Gerrit-Owner: Zfilipin zfili...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits