[MediaWiki-commits] [Gerrit] Fixed Style/AlignParameters RuboCop offense - change (mediawiki...Gather)
Zfilipin has submitted this change and it was merged. Change subject: Fixed Style/AlignParameters RuboCop offense .. Fixed Style/AlignParameters RuboCop offense Bug: T112099 Change-Id: Ibf6d531909c7683f42a4ef29a8a91d035d6ed306 --- M .rubocop_todo.yml M tests/browser/features/support/pages/gather_page.rb 2 files changed, 2 insertions(+), 9 deletions(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b20ef8d..2c03609 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -10,10 +10,3 @@ # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: Max: 112 - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/AlignParameters: - Exclude: -- 'tests/browser/features/support/pages/gather_page.rb' diff --git a/tests/browser/features/support/pages/gather_page.rb b/tests/browser/features/support/pages/gather_page.rb index 4f4f1d0..ce84e57 100644 --- a/tests/browser/features/support/pages/gather_page.rb +++ b/tests/browser/features/support/pages/gather_page.rb @@ -8,9 +8,9 @@ text_field(:edit_overlay_title, css: '.collection-editor-overlay .editor-pane .title') textarea(:edit_overlay_description, css: '.collection-editor-overlay .description') button(:edit_overlay_save_desc, -css: '.collection-editor-overlay .save-description') + css: '.collection-editor-overlay .save-description') button(:edit_overlay_done, -css: '.collection-editor-overlay .overlay-action .save') + css: '.collection-editor-overlay .overlay-action .save') div(:collection_items, css: '.collection-cards') h1(:collection_title, css: '.collection-header h1') div(:collection_description, css: '.collection-description') -- To view, visit https://gerrit.wikimedia.org/r/237599 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf6d531909c7683f42a4ef29a8a91d035d6ed306 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: ZfilipinGerrit-Reviewer: Dduvall Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: Zfilipin Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Style/AlignParameters RuboCop offense - change (mediawiki...Gather)
Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/237599 Change subject: Fixed Style/AlignParameters RuboCop offense .. Fixed Style/AlignParameters RuboCop offense Bug: T112099 Change-Id: Ibf6d531909c7683f42a4ef29a8a91d035d6ed306 --- M .rubocop_todo.yml M tests/browser/features/support/pages/gather_page.rb 2 files changed, 2 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather refs/changes/99/237599/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b20ef8d..2c03609 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -10,10 +10,3 @@ # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: Max: 112 - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/AlignParameters: - Exclude: -- 'tests/browser/features/support/pages/gather_page.rb' diff --git a/tests/browser/features/support/pages/gather_page.rb b/tests/browser/features/support/pages/gather_page.rb index 4f4f1d0..ce84e57 100644 --- a/tests/browser/features/support/pages/gather_page.rb +++ b/tests/browser/features/support/pages/gather_page.rb @@ -8,9 +8,9 @@ text_field(:edit_overlay_title, css: '.collection-editor-overlay .editor-pane .title') textarea(:edit_overlay_description, css: '.collection-editor-overlay .description') button(:edit_overlay_save_desc, -css: '.collection-editor-overlay .save-description') + css: '.collection-editor-overlay .save-description') button(:edit_overlay_done, -css: '.collection-editor-overlay .overlay-action .save') + css: '.collection-editor-overlay .overlay-action .save') div(:collection_items, css: '.collection-cards') h1(:collection_title, css: '.collection-header h1') div(:collection_description, css: '.collection-description') -- To view, visit https://gerrit.wikimedia.org/r/237599 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf6d531909c7683f42a4ef29a8a91d035d6ed306 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Gather Gerrit-Branch: master Gerrit-Owner: Zfilipin___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits