[MediaWiki-commits] [Gerrit] Fixed Style/StringLiterals RuboCop offense - change (mediawiki...PdfHandler)
jenkins-bot has submitted this change and it was merged. Change subject: Fixed Style/StringLiterals RuboCop offense .. Fixed Style/StringLiterals RuboCop offense See: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals Bug: T117986 Change-Id: I60b1598831bbe9fe84c40bf82434cfd22cdd7eff --- M .rubocop.yml D .rubocop_todo.yml M Gemfile M Rakefile M tests/browser/features/support/env.rb M tests/browser/features/support/pages/random_page.rb 6 files changed, 14 insertions(+), 30 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml index 870a41b..84567a5 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,3 @@ -inherit_from: .rubocop_todo.yml - AllCops: StyleGuideCopsOnly: true @@ -15,9 +13,8 @@ Style/SignalException: Enabled: false -# uncomment when fixed -# Style/StringLiterals: -# EnforcedStyle: single_quotes +Style/StringLiterals: + EnforcedStyle: single_quotes Style/TrivialAccessors: ExactNameMatch: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index f0de6d2..000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,13 +0,0 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2015-11-25 15:48:57 +0100 using RuboCop version 0.35.1. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 15 -# Cop supports --auto-correct. -# Configuration parameters: SupportedStyles. -Style/StringLiterals: - EnforcedStyle: double_quotes diff --git a/Gemfile b/Gemfile index 429c07d..b87770d 100644 --- a/Gemfile +++ b/Gemfile @@ -1,4 +1,4 @@ -source "https://rubygems.org"; +source 'https://rubygems.org' -gem "mediawiki_selenium", "~> 1.6.2" -gem "rubocop", "~> 0.35.1", require: false +gem 'mediawiki_selenium', '~> 1.6.2' +gem 'rubocop', '~> 0.35.1', require: false diff --git a/Rakefile b/Rakefile index 4835bcd..3342a96 100644 --- a/Rakefile +++ b/Rakefile @@ -1,14 +1,14 @@ -require "bundler/setup" +require 'bundler/setup' -require "rubocop/rake_task" +require 'rubocop/rake_task' RuboCop::RakeTask.new(:rubocop) do |task| # If you use mediawiki-vagrant, rubocop will by default use it's .rubocop.yml # The next line makes it explicit that you want .rubocop.yml from the # directory where `bundle exec rake` is executed: - task.options = ["-c", ".rubocop.yml"] + task.options = ['-c', '.rubocop.yml'] end task default: [:test] -desc "Run all build/tests commands (CI entry point)" +desc 'Run all build/tests commands (CI entry point)' task test: [:rubocop] diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb index 1760965..c1072b2 100644 --- a/tests/browser/features/support/env.rb +++ b/tests/browser/features/support/env.rb @@ -1,3 +1,3 @@ -require "mediawiki_selenium/cucumber" -require "mediawiki_selenium/pages" -require "mediawiki_selenium/step_definitions" +require 'mediawiki_selenium/cucumber' +require 'mediawiki_selenium/pages' +require 'mediawiki_selenium/step_definitions' diff --git a/tests/browser/features/support/pages/random_page.rb b/tests/browser/features/support/pages/random_page.rb index 8d77e97..8dc4e90 100644 --- a/tests/browser/features/support/pages/random_page.rb +++ b/tests/browser/features/support/pages/random_page.rb @@ -12,6 +12,6 @@ class PdfPage include PageObject - a(:download_as_pdf, text: "Download as PDF") - a(:download_the_file, text: "Download the file") + a(:download_as_pdf, text: 'Download as PDF') + a(:download_the_file, text: 'Download the file') end -- To view, visit https://gerrit.wikimedia.org/r/255391 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60b1598831bbe9fe84c40bf82434cfd22cdd7eff Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PdfHandler Gerrit-Branch: master Gerrit-Owner: Zfilipin Gerrit-Reviewer: Dduvall Gerrit-Reviewer: Hashar Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Style/StringLiterals RuboCop offense - change (mediawiki...PdfHandler)
Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/255391 Change subject: Fixed Style/StringLiterals RuboCop offense .. Fixed Style/StringLiterals RuboCop offense See: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals Bug: T117986 Change-Id: I60b1598831bbe9fe84c40bf82434cfd22cdd7eff --- M .rubocop.yml D .rubocop_todo.yml M Gemfile M Rakefile M tests/browser/features/support/env.rb M tests/browser/features/support/pages/random_page.rb 6 files changed, 14 insertions(+), 30 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PdfHandler refs/changes/91/255391/1 diff --git a/.rubocop.yml b/.rubocop.yml index 870a41b..84567a5 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,3 @@ -inherit_from: .rubocop_todo.yml - AllCops: StyleGuideCopsOnly: true @@ -15,9 +13,8 @@ Style/SignalException: Enabled: false -# uncomment when fixed -# Style/StringLiterals: -# EnforcedStyle: single_quotes +Style/StringLiterals: + EnforcedStyle: single_quotes Style/TrivialAccessors: ExactNameMatch: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index f0de6d2..000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,13 +0,0 @@ -# This configuration was generated by -# `rubocop --auto-gen-config` -# on 2015-11-25 15:48:57 +0100 using RuboCop version 0.35.1. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 15 -# Cop supports --auto-correct. -# Configuration parameters: SupportedStyles. -Style/StringLiterals: - EnforcedStyle: double_quotes diff --git a/Gemfile b/Gemfile index 429c07d..b87770d 100644 --- a/Gemfile +++ b/Gemfile @@ -1,4 +1,4 @@ -source "https://rubygems.org"; +source 'https://rubygems.org' -gem "mediawiki_selenium", "~> 1.6.2" -gem "rubocop", "~> 0.35.1", require: false +gem 'mediawiki_selenium', '~> 1.6.2' +gem 'rubocop', '~> 0.35.1', require: false diff --git a/Rakefile b/Rakefile index 4835bcd..3342a96 100644 --- a/Rakefile +++ b/Rakefile @@ -1,14 +1,14 @@ -require "bundler/setup" +require 'bundler/setup' -require "rubocop/rake_task" +require 'rubocop/rake_task' RuboCop::RakeTask.new(:rubocop) do |task| # If you use mediawiki-vagrant, rubocop will by default use it's .rubocop.yml # The next line makes it explicit that you want .rubocop.yml from the # directory where `bundle exec rake` is executed: - task.options = ["-c", ".rubocop.yml"] + task.options = ['-c', '.rubocop.yml'] end task default: [:test] -desc "Run all build/tests commands (CI entry point)" +desc 'Run all build/tests commands (CI entry point)' task test: [:rubocop] diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb index 1760965..c1072b2 100644 --- a/tests/browser/features/support/env.rb +++ b/tests/browser/features/support/env.rb @@ -1,3 +1,3 @@ -require "mediawiki_selenium/cucumber" -require "mediawiki_selenium/pages" -require "mediawiki_selenium/step_definitions" +require 'mediawiki_selenium/cucumber' +require 'mediawiki_selenium/pages' +require 'mediawiki_selenium/step_definitions' diff --git a/tests/browser/features/support/pages/random_page.rb b/tests/browser/features/support/pages/random_page.rb index 8d77e97..8dc4e90 100644 --- a/tests/browser/features/support/pages/random_page.rb +++ b/tests/browser/features/support/pages/random_page.rb @@ -12,6 +12,6 @@ class PdfPage include PageObject - a(:download_as_pdf, text: "Download as PDF") - a(:download_the_file, text: "Download the file") + a(:download_as_pdf, text: 'Download as PDF') + a(:download_the_file, text: 'Download the file') end -- To view, visit https://gerrit.wikimedia.org/r/255391 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I60b1598831bbe9fe84c40bf82434cfd22cdd7eff Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PdfHandler Gerrit-Branch: master Gerrit-Owner: Zfilipin ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
