[MediaWiki-commits] [Gerrit] Fixing a compat to core migration error in flickrripper.py. - change (pywikibot/core)

2015-03-13 Thread Prianka (Code Review) 
Prianka has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/196632

Change subject: Fixing a compat to core migration error in flickrripper.py.
..

Fixing a compat to core migration error in flickrripper.py.

Correcting error due to mistakenly calling undeclared function 'run' by Tkdialog
in the script which is renamed as show_dialog in present implementation in core.

Change-Id: I2741b092a003390989aac725c3b7c313234fa04f
---
M scripts/flickrripper.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/32/196632/1

diff --git a/scripts/flickrripper.py b/scripts/flickrripper.py
index e7cd008..433ee2a 100644
--- a/scripts/flickrripper.py
+++ b/scripts/flickrripper.py
@@ -297,7 +297,7 @@
 if Tkdialog is not None and not autonomous:
 try:
 (newPhotoDescription, newFilename, skip) = Tkdialog(
-photoDescription, photo, filename).run()
+photoDescription, photo, filename).show_dialog()
 except ImportError as e:
 pywikibot.warning(e)
 pywikibot.warning('Switching to autonomous mode.')

-- 
To view, visit https://gerrit.wikimedia.org/r/196632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2741b092a003390989aac725c3b7c313234fa04f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Prianka priyankajayaswal...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixing a compat to core migration error in flickrripper.py. - change (pywikibot/core)

2015-03-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fixing a compat to core migration error in flickrripper.py.
..


Fixing a compat to core migration error in flickrripper.py.

Correcting error due to mistakenly calling undeclared function 'run' by
Tkdialog in the script which is renamed as show_dialog in present
implementation in core.

Change-Id: I2741b092a003390989aac725c3b7c313234fa04f
---
M scripts/flickrripper.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  XZise: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/flickrripper.py b/scripts/flickrripper.py
index e7cd008..433ee2a 100644
--- a/scripts/flickrripper.py
+++ b/scripts/flickrripper.py
@@ -297,7 +297,7 @@
 if Tkdialog is not None and not autonomous:
 try:
 (newPhotoDescription, newFilename, skip) = Tkdialog(
-photoDescription, photo, filename).run()
+photoDescription, photo, filename).show_dialog()
 except ImportError as e:
 pywikibot.warning(e)
 pywikibot.warning('Switching to autonomous mode.')

-- 
To view, visit https://gerrit.wikimedia.org/r/196632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2741b092a003390989aac725c3b7c313234fa04f
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Prianka priyankajayaswal...@gmail.com
Gerrit-Reviewer: John Vandenberg jay...@gmail.com
Gerrit-Reviewer: Ladsgroup ladsgr...@gmail.com
Gerrit-Reviewer: Merlijn van Deen valhall...@arctus.nl
Gerrit-Reviewer: XZise commodorefabia...@gmx.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits