[MediaWiki-commits] [Gerrit] FormStart crashes when the page title exists and is a redirect - change (mediawiki...SemanticForms)

2016-06-13 Thread Yaron Koren (Code Review) 
Yaron Koren has submitted this change and it was merged.

Change subject: FormStart crashes when the page title exists and is a redirect
..


FormStart crashes when the page title exists and is a redirect

Bug: T137663
Change-Id: I8431c48e6d68fa92832c68263b8bd10a0adbfe69
---
M specials/SF_FormStart.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/specials/SF_FormStart.php b/specials/SF_FormStart.php
index fce6a13..be81dad 100644
--- a/specials/SF_FormStart.php
+++ b/specials/SF_FormStart.php
@@ -136,7 +136,7 @@
$content = WikiPage::factory( $page_title 
)->getContent();
if ( $content && $content->getRedirectTarget() ) {
$page_title = $content->getRedirectTarget();
-   $page_name = SFUtils::titleURLString( 
$redirect_title );
+   $page_name = SFUtils::titleURLString( 
$page_title );
}
// HACK - if this is the default form for
// this page, send to the regular 'formedit'

-- 
To view, visit https://gerrit.wikimedia.org/r/293965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8431c48e6d68fa92832c68263b8bd10a0adbfe69
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Seb35 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] FormStart crashes when the page title exists and is a redirect - change (mediawiki...SemanticForms)

2016-06-12 Thread Seb35 (Code Review) 
Seb35 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293965

Change subject: FormStart crashes when the page title exists and is a redirect
..

FormStart crashes when the page title exists and is a redirect

Bug: T137663
Change-Id: I8431c48e6d68fa92832c68263b8bd10a0adbfe69
---
M specials/SF_FormStart.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms 
refs/changes/65/293965/1

diff --git a/specials/SF_FormStart.php b/specials/SF_FormStart.php
index fce6a13..be81dad 100644
--- a/specials/SF_FormStart.php
+++ b/specials/SF_FormStart.php
@@ -136,7 +136,7 @@
$content = WikiPage::factory( $page_title 
)->getContent();
if ( $content && $content->getRedirectTarget() ) {
$page_title = $content->getRedirectTarget();
-   $page_name = SFUtils::titleURLString( 
$redirect_title );
+   $page_name = SFUtils::titleURLString( 
$page_title );
}
// HACK - if this is the default form for
// this page, send to the regular 'formedit'

-- 
To view, visit https://gerrit.wikimedia.org/r/293965
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8431c48e6d68fa92832c68263b8bd10a0adbfe69
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Seb35 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits