[MediaWiki-commits] [Gerrit] Fully comment code out - change (mediawiki...Wikibase)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Fully comment code out
..


Fully comment code out

When partially done, this shows up when looking for unused code

Change-Id: I45d9d2c4a1a4f27202451a8225561f89ff521cb9
---
M repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php 
b/repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php
index 7c3f2b8..6df210f 100644
--- a/repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php
+++ b/repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php
@@ -111,11 +111,11 @@
new AliasGroupList()
);
 
-   $dupeAliasFingerprint = new Fingerprint(
-   new TermList( array( new Term( 'de', 'good' ) ) ),
-   new TermList(),
-   new AliasGroupList( array( new AliasGroup( 'de', array( 
'DUPE' ) ) ) )
-   );
+// $dupeAliasFingerprint = new Fingerprint(
+// new TermList( array( new Term( 'de', 'good' ) ) ),
+// new TermList(),
+// new AliasGroupList( array( new AliasGroup( 'de', array( 
'DUPE' ) ) ) )
+// );
 
return array(
'conflicting label' => array( $dupeLabelFingerprint, 
'label-conflict' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/257584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I45d9d2c4a1a4f27202451a8225561f89ff521cb9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fully comment code out - change (mediawiki...Wikibase)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/257584

Change subject: Fully comment code out
..

Fully comment code out

When partially done, this shows up when looking for unused code

Change-Id: I45d9d2c4a1a4f27202451a8225561f89ff521cb9
---
M repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/84/257584/1

diff --git 
a/repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php 
b/repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php
index 7c3f2b8..6df210f 100644
--- a/repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php
+++ b/repo/tests/phpunit/includes/Validators/LabelUniquenessValidatorTest.php
@@ -111,11 +111,11 @@
new AliasGroupList()
);
 
-   $dupeAliasFingerprint = new Fingerprint(
-   new TermList( array( new Term( 'de', 'good' ) ) ),
-   new TermList(),
-   new AliasGroupList( array( new AliasGroup( 'de', array( 
'DUPE' ) ) ) )
-   );
+// $dupeAliasFingerprint = new Fingerprint(
+// new TermList( array( new Term( 'de', 'good' ) ) ),
+// new TermList(),
+// new AliasGroupList( array( new AliasGroup( 'de', array( 
'DUPE' ) ) ) )
+// );
 
return array(
'conflicting label' => array( $dupeLabelFingerprint, 
'label-conflict' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/257584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45d9d2c4a1a4f27202451a8225561f89ff521cb9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits