[MediaWiki-commits] [Gerrit] Give editor an empty label to prevent rendering bug - change (mediawiki...MobileFrontend)

2014-12-18 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/180772

Change subject: Give editor an empty label to prevent rendering bug
..

Give editor an empty label to prevent rendering bug

An empty button tag generates extra height, throwing all the vertical
alignment off slightly.

Change-Id: Ic9ab6856959947cfda562afb943a230283910599
---
M javascripts/modules/editor/EditorOverlayBase.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/72/180772/1

diff --git a/javascripts/modules/editor/EditorOverlayBase.js 
b/javascripts/modules/editor/EditorOverlayBase.js
index 0b6d5b7..41c5edd 100644
--- a/javascripts/modules/editor/EditorOverlayBase.js
+++ b/javascripts/modules/editor/EditorOverlayBase.js
@@ -46,6 +46,8 @@
switcherButton: new Icon( {
tagName: 'button',
name: 'edit-switch',
+   // Label required to prevent height rendering 
bug
+   label: 'nbsp;',
additionalClassNames: 'editor-switcher'
} ).toHtmlString(),
sourceButton: new Icon( {

-- 
To view, visit https://gerrit.wikimedia.org/r/180772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9ab6856959947cfda562afb943a230283910599
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders esand...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Give editor an empty label to prevent rendering bug - change (mediawiki...MobileFrontend)

2014-12-18 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Give editor an empty label to prevent rendering bug
..


Give editor an empty label to prevent rendering bug

An empty button tag generates extra height, throwing all the vertical
alignment off slightly.

Change-Id: Ic9ab6856959947cfda562afb943a230283910599
---
M javascripts/modules/editor/EditorOverlayBase.js
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/javascripts/modules/editor/EditorOverlayBase.js 
b/javascripts/modules/editor/EditorOverlayBase.js
index 0b6d5b7..2a91e6b 100644
--- a/javascripts/modules/editor/EditorOverlayBase.js
+++ b/javascripts/modules/editor/EditorOverlayBase.js
@@ -46,6 +46,8 @@
switcherButton: new Icon( {
tagName: 'button',
name: 'edit-switch',
+   // Label required to prevent height rendering 
bug
+   label: '\u00a0',
additionalClassNames: 'editor-switcher'
} ).toHtmlString(),
sourceButton: new Icon( {

-- 
To view, visit https://gerrit.wikimedia.org/r/180772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9ab6856959947cfda562afb943a230283910599
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders esand...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits