[MediaWiki-commits] [Gerrit] Immediately trigger new scroll event after adding infinite s... - change (mediawiki...Flow)

2014-01-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Immediately trigger new scroll event after adding infinite 
scoll content
..


Immediately trigger new scroll event after adding infinite scoll content

Bug: 58935
Change-Id: I801a92af7919cb460aeeda01260528bc4a23f1ff
---
M modules/discussion/paging.js
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Werdna: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/discussion/paging.js b/modules/discussion/paging.js
index 72b8526..62d9e9b 100644
--- a/modules/discussion/paging.js
+++ b/modules/discussion/paging.js
@@ -89,6 +89,12 @@
$pagingLinkDiv.next( '.flow-error' 
).remove();
$pagingLinkDiv.replaceWith( 
$replaceContent );
$replaceContent.trigger( 'flow_init' );
+
+   // trigger a new scroll, to check if 
new data should not be
+   // fetched already (e.g. if all 
comments were deleted, this
+   // batch may have come up empty, in 
which case we need to
+   // load new data immediately, not wait 
for another scroll)
+   $( window ).trigger( 'scroll' );
} )
.fail( function () {
$( 'div/' )

-- 
To view, visit https://gerrit.wikimedia.org/r/106249
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I801a92af7919cb460aeeda01260528bc4a23f1ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org
Gerrit-Reviewer: Werdna agarr...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Immediately trigger new scroll event after adding infinite s... - change (mediawiki...Flow)

2014-01-08 Thread Matthias Mullie (Code Review) 
Matthias Mullie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/106249


Change subject: Immediately trigger new scroll event after adding infinite 
scoll content
..

Immediately trigger new scroll event after adding infinite scoll content

Bug: 58935
Change-Id: I801a92af7919cb460aeeda01260528bc4a23f1ff
---
M modules/discussion/paging.js
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/49/106249/1

diff --git a/modules/discussion/paging.js b/modules/discussion/paging.js
index 72b8526..62d9e9b 100644
--- a/modules/discussion/paging.js
+++ b/modules/discussion/paging.js
@@ -89,6 +89,12 @@
$pagingLinkDiv.next( '.flow-error' 
).remove();
$pagingLinkDiv.replaceWith( 
$replaceContent );
$replaceContent.trigger( 'flow_init' );
+
+   // trigger a new scroll, to check if 
new data should not be
+   // fetched already (e.g. if all 
comments were deleted, this
+   // batch may have come up empty, in 
which case we need to
+   // load new data immediately, not wait 
for another scroll)
+   $( window ).trigger( 'scroll' );
} )
.fail( function () {
$( 'div/' )

-- 
To view, visit https://gerrit.wikimedia.org/r/106249
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I801a92af7919cb460aeeda01260528bc4a23f1ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits