[MediaWiki-commits] [Gerrit] Increase socket timeout allowance for Icinga Puppetmaster HT... - change (operations/puppet)

2013-09-16 Thread Faidon Liambotis (Code Review) 
Faidon Liambotis has submitted this change and it was merged.

Change subject: Increase socket timeout allowance for Icinga Puppetmaster HTTPS 
check
..


Increase socket timeout allowance for Icinga Puppetmaster HTTPS check

This check is flapping constantly and making #wikimedia-operations borderline
unusable unless you /ignore icinga-wm. The default timeout of 10 seconds ought
to be enough but isn't. It won't help to pretend stafford is more performant
than it actually is. Setting it to 30 with the hope that it reduces the noise.

Change-Id: I613a03810b2b1d5c48b52e3c4d3dc0a9a1ca4c1c
---
M templates/icinga/checkcommands.cfg.erb
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Faidon Liambotis: Verified; Looks good to me, approved



diff --git a/templates/icinga/checkcommands.cfg.erb 
b/templates/icinga/checkcommands.cfg.erb
index de6d57c..e81c52f 100644
--- a/templates/icinga/checkcommands.cfg.erb
+++ b/templates/icinga/checkcommands.cfg.erb
@@ -81,9 +81,10 @@
 }
 
 # 'check_http' on a puppetmaster (SSL,port 8140,expect 400)
+# XXX(ori-l, 8-Sep-2013): set timeout to 30 (-t 30) to prevent flapping.
 define command{
command_namecheck_http_puppetmaster
-   command_line$USER1$/check_http --ssl -p 8140 -e 400 -H $HOSTADDRESS$
+   command_line$USER1$/check_http --ssl -p 8140 -e 400 -t 30 -H 
$HOSTADDRESS$
}
 
 # Example usage:  check_solr!500:1000|5

-- 
To view, visit https://gerrit.wikimedia.org/r/83360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I613a03810b2b1d5c48b52e3c4d3dc0a9a1ca4c1c
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Faidon Liambotis fai...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Ryan Lane rl...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Increase socket timeout allowance for Icinga Puppetmaster HT... - change (operations/puppet)

2013-09-08 Thread Ori.livneh (Code Review) 
Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/83360


Change subject: Increase socket timeout allowance for Icinga Puppetmaster HTTPS 
check
..

Increase socket timeout allowance for Icinga Puppetmaster HTTPS check

This check is flapping constantly and making #wikimedia-operations borderline
unusable unless you /ignore icinga-wm. The default timeout of 10 seconds ought
to be enough but isn't. It won't help to pretend stafford is more performant
than it actually is. Setting it to 30 with the hope that it reduces the noise.

Change-Id: I613a03810b2b1d5c48b52e3c4d3dc0a9a1ca4c1c
---
M templates/icinga/checkcommands.cfg.erb
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/60/83360/1

diff --git a/templates/icinga/checkcommands.cfg.erb 
b/templates/icinga/checkcommands.cfg.erb
index 921fe39..42b6b03 100644
--- a/templates/icinga/checkcommands.cfg.erb
+++ b/templates/icinga/checkcommands.cfg.erb
@@ -81,9 +81,10 @@
 }
 
 # 'check_http' on a puppetmaster (SSL,port 8140,expect 400)
+# XXX(ori-l, 8-Sep-2013): set timeout to 30 (-t 30) to prevent flapping.
 define command{
command_namecheck_http_puppetmaster
-   command_line$USER1$/check_http --ssl -p 8140 -e 400 -H $HOSTADDRESS$
+   command_line$USER1$/check_http --ssl -p 8140 -e 400 -t 30 -H 
$HOSTADDRESS$
}
 
 # Example usage:  check_solr!500:1000|5

-- 
To view, visit https://gerrit.wikimedia.org/r/83360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I613a03810b2b1d5c48b52e3c4d3dc0a9a1ca4c1c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh o...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits