[MediaWiki-commits] [Gerrit] Language pairs of different direction and without MT: No def... - change (mediawiki...ContentTranslation)

2015-05-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Language pairs of different direction and without MT: No 
default translation
..


Language pairs of different direction and without MT: No default translation

Bug: T99832
Change-Id: Ib7699a388b92890fd7113272a7b36356112d1e2b
---
M modules/tools/ext.cx.tools.mt.js
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  KartikMistry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/tools/ext.cx.tools.mt.js b/modules/tools/ext.cx.tools.mt.js
index 69321e5..29e69c1 100644
--- a/modules/tools/ext.cx.tools.mt.js
+++ b/modules/tools/ext.cx.tools.mt.js
@@ -43,6 +43,14 @@
 
if ( $.isEmptyObject( MTControlCard.providers ) 
) {
MTControlCard.provider = noMT;
+   // For languages with different 
directionality,
+   // provide disable MT as default 
option. It gives
+   // an empty editor to translator.
+   if ( $.uls.data.getDir( 
mw.cx.sourceLanguage ) !==
+   $.uls.data.getDir( 
mw.cx.targetLanguage )
+   ) {
+   MTControlCard.provider = 
disableMT;
+   }
} else {
// TODO Consider user preferences
MTControlCard.provider = 
MTControlCard.providers[ 0 ];

-- 
To view, visit https://gerrit.wikimedia.org/r/213531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7699a388b92890fd7113272a7b36356112d1e2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Language pairs of different direction and without MT: No def... - change (mediawiki...ContentTranslation)

2015-05-25 Thread Santhosh (Code Review) 
Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/213531

Change subject: Language pairs of different direction and without MT: No 
default translation
..

Language pairs of different direction and without MT: No default translation

Bug: T99832
Change-Id: Ib7699a388b92890fd7113272a7b36356112d1e2b
---
M modules/tools/ext.cx.tools.mt.js
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/31/213531/1

diff --git a/modules/tools/ext.cx.tools.mt.js b/modules/tools/ext.cx.tools.mt.js
index 69321e5..29e69c1 100644
--- a/modules/tools/ext.cx.tools.mt.js
+++ b/modules/tools/ext.cx.tools.mt.js
@@ -43,6 +43,14 @@
 
if ( $.isEmptyObject( MTControlCard.providers ) 
) {
MTControlCard.provider = noMT;
+   // For languages with different 
directionality,
+   // provide disable MT as default 
option. It gives
+   // an empty editor to translator.
+   if ( $.uls.data.getDir( 
mw.cx.sourceLanguage ) !==
+   $.uls.data.getDir( 
mw.cx.targetLanguage )
+   ) {
+   MTControlCard.provider = 
disableMT;
+   }
} else {
// TODO Consider user preferences
MTControlCard.provider = 
MTControlCard.providers[ 0 ];

-- 
To view, visit https://gerrit.wikimedia.org/r/213531
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7699a388b92890fd7113272a7b36356112d1e2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits