[MediaWiki-commits] [Gerrit] Load scripts in debug mode - change (mediawiki...Kartographer)

2016-03-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Load scripts in debug mode
..


Load scripts in debug mode

Bug: T124633
Change-Id: I82d1366428e529c541297e6848fa0e71678c270c
---
M includes/DataModule.php
1 file changed, 9 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/DataModule.php b/includes/DataModule.php
index 31e7efd..e6289fb 100644
--- a/includes/DataModule.php
+++ b/includes/DataModule.php
@@ -31,4 +31,13 @@
public function enableModuleContentVersion() {
return true;
}
+
+   /**
+* @see ResourceLoaderModule::supportsURLLoading
+*
+* @return bool
+*/
+   public function supportsURLLoading() {
+   return false; // always use getScript() to acquire JavaScript 
(even in debug mode)
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/274926
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82d1366428e529c541297e6848fa0e71678c270c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: Yurik 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Load scripts in debug mode - change (mediawiki...Kartographer)

2016-03-04 Thread Yurik (Code Review) 
Yurik has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/274926

Change subject: Load scripts in debug mode
..

Load scripts in debug mode

Bug: T124633
Change-Id: I82d1366428e529c541297e6848fa0e71678c270c
---
M includes/DataModule.php
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/26/274926/1

diff --git a/includes/DataModule.php b/includes/DataModule.php
index 31e7efd..e6289fb 100644
--- a/includes/DataModule.php
+++ b/includes/DataModule.php
@@ -31,4 +31,13 @@
public function enableModuleContentVersion() {
return true;
}
+
+   /**
+* @see ResourceLoaderModule::supportsURLLoading
+*
+* @return bool
+*/
+   public function supportsURLLoading() {
+   return false; // always use getScript() to acquire JavaScript 
(even in debug mode)
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/274926
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82d1366428e529c541297e6848fa0e71678c270c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: Yurik 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits