[MediaWiki-commits] [Gerrit] Loads PageTarget all the time with VisualEditorPluginModules - change (mediawiki...ProofreadPage)

[Tpt (Code Review)]

Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/296052

Change subject: Loads PageTarget all the time with VisualEditorPluginModules
......................................................................

Loads PageTarget all the time with VisualEditorPluginModules

Bug: T138644
Change-Id: Ic4cbb756033523a537d9e6e2bb4b84cf52ce4369
---
M ProofreadPage.body.php
M extension.json
D modules/ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js
3 files changed, 2 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/52/296052/1

diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index 899678d..776e39c 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -174,7 +174,6 @@
                        $out->addModuleStyles( 'ext.proofreadpage.base' );
                } elseif ( $title->inNamespace( self::getPageNamespaceId() ) ) {
                        $out->addModules( 'ext.proofreadpage.page.navigation' );
-                       $out->addModules( 
'ext.proofreadpage.ve.pageTarget.init' );
                } elseif (
                        $title->inNamespace( NS_MAIN ) &&
                        ( $out->isArticle() || $isEdit ) &&
diff --git a/extension.json b/extension.json
index cc78d35..793d39e 100644
--- a/extension.json
+++ b/extension.json
@@ -326,7 +326,8 @@
                "tests/parser/proofreadpage_pagequality.txt"
        ],
        "VisualEditorPluginModules": [
-               "ext.proofreadpage.ve.node.pages"
+               "ext.proofreadpage.ve.node.pages",
+               "ext.proofreadpage.ve.pageTarget"
        ],
        "VisualEditorAvailableNamespaces": {
                "Page": true
diff --git a/modules/ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js 
b/modules/ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js
deleted file mode 100644
index 0d2621d..0000000
--- a/modules/ve/pageTarget/ve.init.mw.ProofreadPagePageTarget.init.js
+++ /dev/null
@@ -1,12 +0,0 @@
-/*!
- * VisualEditor MediaWiki Initialization ProofreadPagePageTarget 
initialization.
- *
- * @copyright 2011-2016 VisualEditor Team and others; see AUTHORS.txt
- * @license The MIT License (MIT); see LICENSE.txt
- */
-
-if ( mw.loader.getState( 'ext.visualEditor.desktopArticleTarget.init' ) ) {
-       mw.loader.using( 'ext.visualEditor.desktopArticleTarget.init', function 
() {
-               mw.libs.ve.addPlugin( 'ext.proofreadpage.ve.pageTarget' );
-       } );
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/296052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4cbb756033523a537d9e6e2bb4b84cf52ce4369
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt <thoma...@hotmail.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits