[MediaWiki-commits] [Gerrit] Log an error when WikiGrok is unable to load labels - change (mediawiki...MobileFrontend)

2014-11-04 Thread Bmansurov (Code Review) 
Bmansurov has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/171021

Change subject: Log an error when WikiGrok is unable to load labels
..

Log an error when WikiGrok is unable to load labels

Change-Id: Iae56be9c1ef633acca10a6f28b4bde48815018a8
---
M javascripts/modules/wikigrok/WikiGrokDialog.js
M javascripts/modules/wikigrok/WikiGrokDialogB.js
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/21/171021/1

diff --git a/javascripts/modules/wikigrok/WikiGrokDialog.js 
b/javascripts/modules/wikigrok/WikiGrokDialog.js
index cd03628..4d4cda0 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialog.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialog.js
@@ -184,6 +184,8 @@
} else {
self.showError( options, 'There 
was an error retrieving tag labels.' );
}
+   } ).fail(function () {
+   self.logError( 
'no-impression-cannot-fetch-labels' );
} );
}
},
diff --git a/javascripts/modules/wikigrok/WikiGrokDialogB.js 
b/javascripts/modules/wikigrok/WikiGrokDialogB.js
index 37df6a5..6421360 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialogB.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialogB.js
@@ -98,6 +98,8 @@
self.$( '.spinner' ).hide();
self.show();
}
+   } ).fail(function () {
+   self.logError( 
'no-impression-cannot-fetch-labels' );
} );
}
},

-- 
To view, visit https://gerrit.wikimedia.org/r/171021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae56be9c1ef633acca10a6f28b4bde48815018a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov bmansu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Log an error when WikiGrok is unable to load labels - change (mediawiki...MobileFrontend)

2014-11-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Log an error when WikiGrok is unable to load labels
..


Log an error when WikiGrok is unable to load labels

Change-Id: Iae56be9c1ef633acca10a6f28b4bde48815018a8
---
M javascripts/modules/wikigrok/WikiGrokDialog.js
M javascripts/modules/wikigrok/WikiGrokDialogB.js
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/javascripts/modules/wikigrok/WikiGrokDialog.js 
b/javascripts/modules/wikigrok/WikiGrokDialog.js
index cd03628..4d4cda0 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialog.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialog.js
@@ -184,6 +184,8 @@
} else {
self.showError( options, 'There 
was an error retrieving tag labels.' );
}
+   } ).fail(function () {
+   self.logError( 
'no-impression-cannot-fetch-labels' );
} );
}
},
diff --git a/javascripts/modules/wikigrok/WikiGrokDialogB.js 
b/javascripts/modules/wikigrok/WikiGrokDialogB.js
index 37df6a5..6421360 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialogB.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialogB.js
@@ -98,6 +98,8 @@
self.$( '.spinner' ).hide();
self.show();
}
+   } ).fail(function () {
+   self.logError( 
'no-impression-cannot-fetch-labels' );
} );
}
},

-- 
To view, visit https://gerrit.wikimedia.org/r/171021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae56be9c1ef633acca10a6f28b4bde48815018a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov bmansu...@wikimedia.org
Gerrit-Reviewer: Awjrichards aricha...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits