[MediaWiki-commits] [Gerrit] Make generalizeSQL() protected - change (mediawiki/core)

2015-10-05 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Make generalizeSQL() protected
..


Make generalizeSQL() protected

Change-Id: Ib1317576b82993adf5ae454f9ecd8bd148a58cc9
---
M includes/db/Database.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/db/Database.php b/includes/db/Database.php
index 4bbb491..ab61408 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -1756,7 +1756,7 @@
 *
 * @return string
 */
-   static function generalizeSQL( $sql ) {
+   protected static function generalizeSQL( $sql ) {
# This does the same as the regexp below would do, but in such 
a way
# as to avoid crashing php on some large strings.
# $sql = preg_replace( 
"/'([^']|.)*'|\"([^\"]|.)*\"/", "'X'", $sql );

-- 
To view, visit https://gerrit.wikimedia.org/r/243492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1317576b82993adf5ae454f9ecd8bd148a58cc9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Parent5446 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Make generalizeSQL() protected - change (mediawiki/core)

2015-10-04 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/243492

Change subject: Make generalizeSQL() protected
..

Make generalizeSQL() protected

Change-Id: Ib1317576b82993adf5ae454f9ecd8bd148a58cc9
---
M includes/db/Database.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/243492/1

diff --git a/includes/db/Database.php b/includes/db/Database.php
index 4bbb491..ab61408 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -1756,7 +1756,7 @@
 *
 * @return string
 */
-   static function generalizeSQL( $sql ) {
+   protected static function generalizeSQL( $sql ) {
# This does the same as the regexp below would do, but in such 
a way
# as to avoid crashing php on some large strings.
# $sql = preg_replace( 
"/'([^']|.)*'|\"([^\"]|.)*\"/", "'X'", $sql );

-- 
To view, visit https://gerrit.wikimedia.org/r/243492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1317576b82993adf5ae454f9ecd8bd148a58cc9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits