[MediaWiki-commits] [Gerrit] Make profiling to UDP work again - change (mediawiki/core)

2014-04-14 Thread IAlex (Code Review) 
IAlex has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/125770

Change subject: Make profiling to UDP work again
..

Make profiling to UDP work again

Fix for I1260bab2b5 (afa6af0).

Since $this-mCollated['-total'] is normally always defined,
this would cause no logging to UDP at all.

Change-Id: Ibce1c8662b4b3e99e77723f5377dd654b4f59be1
---
M includes/profiler/ProfilerSimpleUDP.php
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/70/125770/1

diff --git a/includes/profiler/ProfilerSimpleUDP.php 
b/includes/profiler/ProfilerSimpleUDP.php
index e9bcff6..dfe923d 100644
--- a/includes/profiler/ProfilerSimpleUDP.php
+++ b/includes/profiler/ProfilerSimpleUDP.php
@@ -41,11 +41,6 @@
 
$this-close();
 
-   if ( isset( $this-mCollated['-total'] ) ) {
-   # Less than minimum, ignore
-   return;
-   }
-
if ( !function_exists( 'socket_create' ) ) {
# Sockets are not enabled
return;

-- 
To view, visit https://gerrit.wikimedia.org/r/125770
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibce1c8662b4b3e99e77723f5377dd654b4f59be1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex coderev...@emsenhuber.ch

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Make profiling to UDP work again - change (mediawiki/core)

2014-04-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Make profiling to UDP work again
..


Make profiling to UDP work again

Fix for I1260bab2b5 (afa6af0).

Since $this-mCollated['-total'] is normally always defined,
this would cause no logging to UDP at all.

Change-Id: Ibce1c8662b4b3e99e77723f5377dd654b4f59be1
---
M includes/profiler/ProfilerSimpleUDP.php
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/profiler/ProfilerSimpleUDP.php 
b/includes/profiler/ProfilerSimpleUDP.php
index e9bcff6..dfe923d 100644
--- a/includes/profiler/ProfilerSimpleUDP.php
+++ b/includes/profiler/ProfilerSimpleUDP.php
@@ -41,11 +41,6 @@
 
$this-close();
 
-   if ( isset( $this-mCollated['-total'] ) ) {
-   # Less than minimum, ignore
-   return;
-   }
-
if ( !function_exists( 'socket_create' ) ) {
# Sockets are not enabled
return;

-- 
To view, visit https://gerrit.wikimedia.org/r/125770
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibce1c8662b4b3e99e77723f5377dd654b4f59be1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex coderev...@emsenhuber.ch
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits