[MediaWiki-commits] [Gerrit] Make sure snaklistview test cases pass in Firefox - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged.
Change subject: Make sure snaklistview test cases pass in Firefox
..
Make sure snaklistview test cases pass in Firefox
Change-Id: I486be0982b87135f8b8d67eb1e4a5b8ae8c7d7df
---
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Addshore: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
index 1079d85..05aefc1 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
@@ -401,6 +401,10 @@
QUnit.start();
} );
+ // We need to make sure the snaklistview is visible before
startEditing,
+ // because Firefox does not allow setting focus on a hidden
element.
+ $node.appendTo( $( 'body' ) );
+
snaklistview.startEditing();
assert.strictEqual(
@@ -448,6 +452,8 @@
// Should not trigger any events since not in edit mode:
snaklistview.stopEditing();
+
+ $node.remove();
} );
QUnit.test( 'enterNewItem()', function( assert ) {
@@ -520,6 +526,10 @@
var $node = createSnaklistview(),
snaklistview = $node.data( 'snaklistview' );
+ // We need to make sure the snaklistview is visible before
startEditing,
+ // because Firefox does not allow setting focus on a hidden
element.
+ $node.appendTo( $( 'body' ) );
+
// Start with empty snaklistview, set a snak list and stop edit
mode:
snaklistview.startEditing();
snaklistview = setValueKeepingInitial( snaklistview,
snakLists[0] );
@@ -569,11 +579,17 @@
snaklistview.isInitialValue(),
'Verified reset to initial value.'
);
+
+ $node.remove();
} );
QUnit.test( 'Stopping edit mode retaining value', function( assert ) {
var $node = createSnaklistview(),
snaklistview = $node.data( 'snaklistview' );
+
+ // We need to make sure the snaklistview is visible before
startEditing,
+ // because Firefox does not allow setting focus on a hidden
element.
+ $node.appendTo( $( 'body' ) );
// Start with empty snaklistview, set a snak list and stop edit
mode:
snaklistview.startEditing();
@@ -637,6 +653,8 @@
null,
'Snaklistview is empty.'
);
+
+ $node.remove();
} );
QUnit.test( 'Dis- and enabling', function( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/106215
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I486be0982b87135f8b8d67eb1e4a5b8ae8c7d7df
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang
Gerrit-Reviewer: Addshore
Gerrit-Reviewer: Henning Snater
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make sure snaklistview test cases pass in Firefox - change (mediawiki...Wikibase)
Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/106215
Change subject: Make sure snaklistview test cases pass in Firefox
..
Make sure snaklistview test cases pass in Firefox
Change-Id: I486be0982b87135f8b8d67eb1e4a5b8ae8c7d7df
---
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/15/106215/1
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
index eb1ecac..abe7f49 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.snaklistview.tests.js
@@ -403,6 +403,10 @@
QUnit.start();
} );
+ // We need to make sure the snaklistview is visible before
startEditing,
+ // because Firefox does not allow setting focus on a hidden
element.
+ $node.appendTo( $( 'body' ) );
+
snaklistview.startEditing();
assert.strictEqual(
@@ -450,6 +454,8 @@
// Should not trigger any events since not in edit mode:
snaklistview.stopEditing();
+
+ $node.remove();
} );
QUnit.test( 'enterNewItem()', function( assert ) {
@@ -522,6 +528,10 @@
var $node = createSnaklistview(),
snaklistview = $node.data( 'snaklistview' );
+ // We need to make sure the snaklistview is visible before
startEditing,
+ // because Firefox does not allow setting focus on a hidden
element.
+ $node.appendTo( $( 'body' ) );
+
// Start with empty snaklistview, set a snak list and stop edit
mode:
snaklistview.startEditing();
snaklistview = setValueKeepingInitial( snaklistview,
snakLists[0] );
@@ -571,11 +581,17 @@
snaklistview.isInitialValue(),
'Verified reset to initial value.'
);
+
+ $node.remove();
} );
QUnit.test( 'Stopping edit mode retaining value', function( assert ) {
var $node = createSnaklistview(),
snaklistview = $node.data( 'snaklistview' );
+
+ // We need to make sure the snaklistview is visible before
startEditing,
+ // because Firefox does not allow setting focus on a hidden
element.
+ $node.appendTo( $( 'body' ) );
// Start with empty snaklistview, set a snak list and stop edit
mode:
snaklistview.startEditing();
@@ -639,6 +655,8 @@
null,
'Snaklistview is empty.'
);
+
+ $node.remove();
} );
QUnit.test( 'Dis- and enabling', function( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/106215
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I486be0982b87135f8b8d67eb1e4a5b8ae8c7d7df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
