[MediaWiki-commits] [Gerrit] Makes user options also work when the value is "1" instead of 1 - change (mediawiki...ProofreadPage)

2016-06-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Makes user options also work when the value is "1" instead of 1
..


Makes user options also work when the value is "1" instead of 1

Change-Id: I51723c7f4b1c4166523605774171466592ecb005
---
M modules/page/ext.proofreadpage.page.edit.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/page/ext.proofreadpage.page.edit.js 
b/modules/page/ext.proofreadpage.page.edit.js
index e75929e..7ed555c 100644
--- a/modules/page/ext.proofreadpage.page.edit.js
+++ b/modules/page/ext.proofreadpage.page.edit.js
@@ -177,7 +177,7 @@
},
$edit = $( '#wpTextbox1' );
 
-   if ( mw.user.options.get( 'usebetatoolbar' ) === 1 ) {
+   if ( mw.user.options.get( 'usebetatoolbar' ) ) {
mw.loader.using( 'ext.wikiEditor.toolbar', function () {
$edit.wikiEditor( 'addToToolbar', {
sections: {
@@ -189,7 +189,7 @@
}
} );
} );
-   } else if ( mw.user.options.get( 'showtoolbar' ) === 1 ) {
+   } else if ( mw.user.options.get( 'showtoolbar' ) ) {
mw.loader.using( 'mediawiki.toolbar', function () {
$.each( tools, function ( group, list ) {
$.each( list.tools, function ( id, def 
) {

-- 
To view, visit https://gerrit.wikimedia.org/r/295644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51723c7f4b1c4166523605774171466592ecb005
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt 
Gerrit-Reviewer: GOIII 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Phe 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Makes user options also work when the value is "1" instead of 1 - change (mediawiki...ProofreadPage)

2016-06-23 Thread Tpt (Code Review) 
Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/295644

Change subject: Makes user options also work when the value is "1" instead of 1
..

Makes user options also work when the value is "1" instead of 1

Change-Id: I51723c7f4b1c4166523605774171466592ecb005
---
M modules/page/ext.proofreadpage.page.edit.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/44/295644/1

diff --git a/modules/page/ext.proofreadpage.page.edit.js 
b/modules/page/ext.proofreadpage.page.edit.js
index e75929e..7ed555c 100644
--- a/modules/page/ext.proofreadpage.page.edit.js
+++ b/modules/page/ext.proofreadpage.page.edit.js
@@ -177,7 +177,7 @@
},
$edit = $( '#wpTextbox1' );
 
-   if ( mw.user.options.get( 'usebetatoolbar' ) === 1 ) {
+   if ( mw.user.options.get( 'usebetatoolbar' ) ) {
mw.loader.using( 'ext.wikiEditor.toolbar', function () {
$edit.wikiEditor( 'addToToolbar', {
sections: {
@@ -189,7 +189,7 @@
}
} );
} );
-   } else if ( mw.user.options.get( 'showtoolbar' ) === 1 ) {
+   } else if ( mw.user.options.get( 'showtoolbar' ) ) {
mw.loader.using( 'mediawiki.toolbar', function () {
$.each( tools, function ( group, list ) {
$.each( list.tools, function ( id, def 
) {

-- 
To view, visit https://gerrit.wikimedia.org/r/295644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51723c7f4b1c4166523605774171466592ecb005
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits