[MediaWiki-commits] [Gerrit] Minor fixes to instrumentation - change (operations...pybal)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Minor fixes to instrumentation
..


Minor fixes to instrumentation

Change-Id: I8c68ed5965703967201066edf1f446dd456d0434
---
M pybal/instrumentation.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Giuseppe Lavagetto: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pybal/instrumentation.py b/pybal/instrumentation.py
index b606ace..0e38cbf 100644
--- a/pybal/instrumentation.py
+++ b/pybal/instrumentation.py
@@ -73,7 +73,7 @@
 if wantJson(request):
 return json.dumps(pools)
 else:
-return "\n".join(pools)
+return "\n".join(pools) + "\n"
 
 
 class PoolServers(Resource):
@@ -102,7 +102,7 @@
 return json.dumps(res)
 else:
 res = ""
-for hostname, server in self.coordinator.server.items():
+for hostname, server in self.coordinator.servers.items():
 res += "{}:\t{}\n".format(hostname, server.textStatus())
 return res
 
@@ -122,4 +122,4 @@
 if wantJson(request):
 return json.dumps(self.server.dumpState())
 else:
-return self.server.textStatus()
+return self.server.textStatus() + "\n"

-- 
To view, visit https://gerrit.wikimedia.org/r/243413
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c68ed5965703967201066edf1f446dd456d0434
Gerrit-PatchSet: 2
Gerrit-Project: operations/debs/pybal
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Lavagetto 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor fixes to instrumentation - change (operations...pybal)

[Giuseppe Lavagetto (Code Review)]

Giuseppe Lavagetto has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/243413

Change subject: Minor fixes to instrumentation
..

Minor fixes to instrumentation

Change-Id: I8c68ed5965703967201066edf1f446dd456d0434
---
M pybal/instrumentation.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/pybal 
refs/changes/13/243413/1

diff --git a/pybal/instrumentation.py b/pybal/instrumentation.py
index b606ace..0e38cbf 100644
--- a/pybal/instrumentation.py
+++ b/pybal/instrumentation.py
@@ -73,7 +73,7 @@
 if wantJson(request):
 return json.dumps(pools)
 else:
-return "\n".join(pools)
+return "\n".join(pools) + "\n"
 
 
 class PoolServers(Resource):
@@ -102,7 +102,7 @@
 return json.dumps(res)
 else:
 res = ""
-for hostname, server in self.coordinator.server.items():
+for hostname, server in self.coordinator.servers.items():
 res += "{}:\t{}\n".format(hostname, server.textStatus())
 return res
 
@@ -122,4 +122,4 @@
 if wantJson(request):
 return json.dumps(self.server.dumpState())
 else:
-return self.server.textStatus()
+return self.server.textStatus() + "\n"

-- 
To view, visit https://gerrit.wikimedia.org/r/243413
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c68ed5965703967201066edf1f446dd456d0434
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/pybal
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Lavagetto 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits